Repository navigation
feat(lockless rendering): prepare for azldev updates to allow lockless rendering - #20006
Open
Dan Streetman (ddstreetmicrosoft) wants to merge 2 commits into
Open
Dan Streetman (ddstreetmicrosoft) wants to merge 2 commits into
Dan Streetman (ddstreetmicrosoft) wants to merge 2 commits into
Conversation
Dan Streetman (ddstreetmicrosoft)
requested a review
from a team
as a code owner
November 5, 2026 21:35
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the configuration include and placeholder changes.
No open issues 🎉
What changed in this PR
Prepares the base project for upcoming azldev support for lockless rendering without implementing that support yet.
Changes:
- Adds
upstream-commits/*.tomlto the base project's configuration includes. - Adds an empty
lockless-components.txtplaceholder.
| File | Description |
|---|---|
lockless-components.txt |
Adds an empty placeholder for lockless-rendering preparation. |
base/project.toml |
Includes upstream-commit TOML files in the base configuration. |
Review effort: Balanced
Thien Trung Vuong (trungams)
approved these changes
Nov 5, 2026
Tobias Brick (tobiasb-ms)
requested changes
Nov 5, 2026
| # | ||
|
|
||
| includes = ["comps/components.toml", "images/images.toml", "images/images.tests.toml"] | ||
| includes = ["upstream-commits/*.toml", "comps/components.toml", "images/images.toml", "images/images.tests.toml"] |
Contributor
There was a problem hiding this comment.
question(blocking): I don't see that we have an upstream-commits folder. Just confirming that that includes can handle non-existent files and directories?
Contributor
Author
There was a problem hiding this comment.
as far as i can tell it does, running update and render works fine.
Contributor
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
…l files work on azldev to transition off using 'lock' files involves moving component upstream commit configuration into separate toml files, which need to be included during toml parsing. this adds a directive to include those files using a glob pattern. since there are currently no matching toml files, this is currently a no-op.
work on azldev to remove use of 'lock' files will transition individual components from using a 'lock' file to 'lockless' rendering. as this is strictly a transitional process, a temporary file named 'lockless-components.txt' at the same level as the 'azldev.toml' file will be used to record which components should use 'lockless' rendering; any not in the file will continue to use 'lock' file rendering. as this file currently contains nothing, this is currently a no-op. after all components are transitioned to 'lockless' rendering, and azldev is updated to remove support for 'lock' files, this file will no longer be needed and should be removed.
Dan Streetman (ddstreetmicrosoft)
force-pushed
the
ddstreet/lockless-prep
branch
from
November 6, 2026 02:06
3bdf7a3 to
628c51f
Compare
Contributor
Author
|
no-change force push to correct my commit subject that was using |
Contributor
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 2 no-op commits in preparation of adding azldev support for lockless rendering.