Repository navigation
fix(llvm): use native azure linux i386 config names - #20005
Tobias Brick (tobiasb-ms) wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the i386 Clang configuration filename alignment.
No open issues 🎉
What changed in this PR
Aligns LLVM 20 and 21’s i386 Clang configuration filenames with Azure Linux’s native target naming, matching the existing x86_64 policy without changing configuration contents.
Changes:
- Adds overlays that rename the C and C++ i386 configurations in installation commands and package file lists.
- Updates rendered specs, release numbers, and changelogs.
- Refreshes component lock fingerprints without changing upstream pins.
| File | Description |
|---|---|
specs/l/llvm20/llvm20.spec |
Applies native i386 filenames and bumps LLVM 20’s release. |
specs/l/llvm/llvm.spec |
Applies native i386 filenames and bumps LLVM 21’s release. |
locks/llvm20.lock |
Refreshes LLVM 20’s input fingerprint. |
locks/llvm.lock |
Refreshes LLVM 21’s input fingerprint. |
base/comps/llvm20/overlays/0003-native-i386-configs.overlay.toml |
Defines LLVM 20’s installation and packaging filename replacements. |
base/comps/llvm/overlays/0003-native-i386-configs.overlay.toml |
Defines LLVM 21’s installation and packaging filename replacements. |
Review effort: Balanced
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
| description = "Use the native Azure Linux i386 target name for the C driver configuration." | ||
| type = "spec-search-replace" | ||
| section = "%install" | ||
| regex = '^echo " %\{cfg_file_content\}" >> %\{buildroot\}%\{_sysconfdir\}/%\{pkg_name_clang\}/i386-redhat-linux-gnu-clang\.cfg$' |
There was a problem hiding this comment.
question(blocking): Can't we simplify all this by just globally searching and replacing i386-redhat-linux-gnu-clang with i386-azurelinux-linux-gnu-clang? That could be a single overlay and catch all instances.
There was a problem hiding this comment.
I had considered that and initially decided against in fear of accidentally changing new instances of that that string if they ever came in.
I rethought that a bit though and:
a) They are unlikely and
b) We probably would want to change them
All of which is to say that I've made that change.
Rename the i386 C/C++ configs to match the native Azure Linux target, mirroring x86_64. Keep their contents unchanged; Red Hat targets use normal discovery. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Rename the i386 C/C++ configs to match the native Azure Linux target, mirroring x86_64. Keep their contents unchanged; Red Hat targets use normal discovery. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
a0bc70b to
71303e2
Compare
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
Rename the LLVM20/21 i386 configs to native Azure Linux names, matching x86_64 policy without changing their contents.
Validated with isolated builds, paired driver checks, and ELF32/64 checks.
Fixes AB#19950