Repository navigation
Skip missing nodes in formatting - #48953
Merged
Andrew Branch (andrewbranch) merged 1 commit intoMay 4, 2022
Merged
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Milestone Bug
Jake Bailey (jakebailey)
left a comment
Jake Bailey (jakebailey)
left a comment
Member
There was a problem hiding this comment.
I assume formatting is called from code fixes, then, given the original traces are all rooted from getCodeFixes, or should the test call via code fixes?
Member
Author
|
In this case you can just take my word that selection-based formatting caused the same crash prior to my fix. Occasionally a formatter crash can only be reproduced with synthesized nodes, but that wasn’t the case here. |
Jake Bailey (jakebailey)
approved these changes
May 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32862 (not the first and not the last time)