Repository navigation
More refactoring of tsc baselines to help with easier updates - #48572
Merged
Merged
Conversation
Sheetal Nandi (sheetalkamat)
requested review from
Andrew Casey (amcasey) and
Andrew Branch (andrewbranch)
April 5, 2022 17:04
| const patch = fs.diff(inputFs, { includeChangedFileWithSameContent: true }); | ||
| return { | ||
| file: `${isBuild(commandLineArgs) ? "tsbuild" : "tsc"}/${scenario}/${buildKind || BuildKind.Initial}/${subScenario.split(" ").join("-")}.js`, | ||
| file: `${isBuild(commandLineArgs) ? "tsbuild" : "tsc"}/${scenario}/${subScenario.split(" ").join("-")}.js`, |
Member
Author
There was a problem hiding this comment.
Removed this one level of unnecessary directory in the baselines
Sheetal Nandi (sheetalkamat)
force-pushed
the
baselining2
branch
2 times, most recently
from
April 5, 2022 17:41
e08d030 to
5632efd
Compare
Sheetal Nandi (sheetalkamat)
force-pushed
the
baselining2
branch
from
April 5, 2022 20:14
5632efd to
1292289
Compare
Sheetal Nandi (sheetalkamat)
force-pushed
the
baselining2
branch
from
April 6, 2022 19:50
1292289 to
f63f0af
Compare
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Andrew Branch (andrewbranch)
approved these changes
Apr 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unnecessary directories in the baselines making one baseline per test.
Also unifies two baseline functions that were doing something similar with slight change.