Repository navigation

ES private class elements - #42458

Merged

Ron Buckton (rbuckton) merged 87 commits into

microsoft:masterfrom

bloomberg:es-private-methods-and-accessors

Mar 25, 2021

Merged

ES private class elements#42458
Ron Buckton (rbuckton) merged 87 commits into
microsoft:masterfrom
bloomberg:es-private-methods-and-accessors

Commits on Feb 3, 2021
- Added support for private identifier methods.
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  e3a3fb8
- Added tests for private methods.
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  4ab27a2
- Added check to only not allow private name method signatures in anything except classes.
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  6977b9f
- Added private accessors tests
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  bc8c07e
- Transform private methods
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  2760ed8
- Rename shouldTransformPrivateFields
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  04af85d
- Accept baseline
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  f048d72
- Use a single WeakSet for brand-check
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  f8cfb81
- Accept baseline
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  4aa4c3b
- Add a test for using private methods in static field initializers
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  0ac1271
- Add breaking checker test
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  7da5bd9
- Add to instances once per-instance
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  e133f60
- Accept baseline
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  aa5dd8a
- fix: evaluate receiver and rhs expressions before throwing on readonly assignment
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  a3889a7
- Add a test for evaluating rhs before readonly assignment
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  8952caa
- Transpile private accessors
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  dee87bb
- Accept baseline
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  aec7e9b
- fix: handle readonly/writeonly accessors
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  f3bbf0f
- accept baseline
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  a1b59cd
- add a test for private setter without a getter
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  6b74498
- fix: getAllUnscopedEmitHelpers
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  d51f6cd
- fix: better handling of duplicate names
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  c175770
- Fixed wrong error message for private methods in class expressions.
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  4301af5
- change error message
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  3a056b2
- add a test for async private methods with a higher target
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  95df2d1
- fix: setter assignment returns rhs value
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  590124e
- add a test for setter assignment return value
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  219ea83
- fix: handle duplicate accessors
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  25da8ca
- add tests for duplicate accessors
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  a2228be
- docs: add missing parameter docs
  
  Kubilay Kahveci (mkubilayk)
  authored and
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  ff4f737
- Fixed failing test.
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  704727c
Commits on Feb 17, 2021
- baseline-accept: ordering changes
  Kubilay Kahveci (mkubilayk)
  committed
  73925dc
- fix: attach weakSetName to property declaration
  Kubilay Kahveci (mkubilayk)
  committed
  67fd38d
- add a test for nested private methods
  Kubilay Kahveci (mkubilayk)
  committed
  45c2a41
- add a test with any
  Kubilay Kahveci (mkubilayk)
  committed
  356b91d
Commits on Feb 18, 2021
Commits on Feb 19, 2021
Commits on Feb 23, 2021
- Added error when using initializers with private static fields when useDefineForClassFields is not specified and target is esnext.
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  62b4f2f
Commits on Feb 24, 2021
- Fixed code review issues.
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  b2a692d
- Removed semantically wrong emit on `useDefineForClassFields:true` with `target:esnext`
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  363041e
Commits on Feb 25, 2021
Commits on Mar 1, 2021
- add debug.assertNever for unknown node type (#53)
  Kubilay Kahveci (mkubilayk)
  authored
  30c7f69
- Merge remote-tracking branch 'upstream/master' into es-private-methods-and-accessors
  Kubilay Kahveci (mkubilayk)
  committed
  c924058
Commits on Mar 2, 2021
- Merge remote-tracking branch 'upstream/master' into es-private-methods-and-accessors
  Kubilay Kahveci (mkubilayk)
  committed
  e65116f
Commits on Mar 3, 2021
Commits on Mar 8, 2021
- Fixes class shadowing when checking access to a private static class element.
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  294cc48
- Merge remote-tracking branch 'remotes/origin/master' into es-private-static-fields-methods-and-accessors
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  027bdb3
Commits on Mar 17, 2021
Commits on Mar 18, 2021
- Merge branch 'es-private-methods-and-accessors' of https://github.com/bloomberg/TypeScript into es-private-methods-and-accessors
  Titian Cernicova-Dragomir (dragomirtitian)
  committed
  2de8a43
- do not allocate a node if not needed in visitMehodDeclaration (#55)
  Kubilay Kahveci (mkubilayk)
  authored
  7490a36
Commits on Mar 22, 2021
Commits on Mar 23, 2021
- update keyof tests and ?? (#62)
  Kubilay Kahveci (mkubilayk)
  authored
  f5816ab
- fix emit helpers comments
  Kubilay Kahveci (mkubilayk)
  committed
  3b62d3c
- produce an error if private field helpers are not up to date
  Kubilay Kahveci (mkubilayk)
  committed
  7d8a2b9
- add tests
  Kubilay Kahveci (mkubilayk)
  committed
  d0d2055
- fix setter-only compound assignment
  Kubilay Kahveci (mkubilayk)
  committed
  93a7ca3
- Merge pull request #63 from bloomberg/helper-parameter-count
  Kubilay Kahveci (mkubilayk)
  authored
  6da2cdd
- fix tests
  Kubilay Kahveci (mkubilayk)
  committed
  30805b7
Commits on Mar 24, 2021
- fix duplicated trailing comments (#64)
  Kubilay Kahveci (mkubilayk)
  authored
  8d77a8e
- clear receiver pos and setTextRange on helper calls
  Kubilay Kahveci (mkubilayk)
  committed
  8078ae0

Commits

Commits on Feb 3, 2021

Commits on Feb 17, 2021

Commits on Feb 18, 2021

Commits on Feb 19, 2021

Commits on Feb 23, 2021

Commits on Feb 24, 2021

Commits on Feb 25, 2021

Commits on Mar 1, 2021

Commits on Mar 2, 2021

Commits on Mar 3, 2021

Commits on Mar 8, 2021

Commits on Mar 17, 2021

Commits on Mar 18, 2021

Commits on Mar 22, 2021

Commits on Mar 23, 2021

Commits on Mar 24, 2021