Repository navigation
Unconstrained type variable not assignable to 'object' - #23806
Merged
Anders Hejlsberg (ahejlsberg) merged 5 commits intoMay 1, 2018
Merged
Conversation
Mohamed Hegazy (mhegazy)
approved these changes
May 1, 2018
Nathan Shively-Sanders (sandersn)
approved these changes
May 1, 2018
Nathan Shively-Sanders (sandersn)
left a comment
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
Looks good, although the tests don't make all the assertions that the comments in the tests do.
| type A<T, V> = { [P in keyof T]: T[P] extends V ? 1 : 0; }; | ||
| type B<T, V> = { [P in keyof T]: T[P] extends V | object ? 1 : 0; }; | ||
|
|
||
| type a = A<{ a: 0 | 1 }, 0>; // { a: 0; } |
There was a problem hiding this comment.
the baselines don't actually show that type a = { a: 0 } (or that type b = { a: 0 }.
Anders Hejlsberg (ahejlsberg)
deleted the
objectAndUnconstrainedTypeParameter
branch
May 1, 2018 20:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23800.