Repository navigation
TypeScript Should Allow for Suppressing Definition Errors Sourced from External Definition Files #8124
Description
Issues with bundled NPM definition files out in the wild with Microsoft/BotBuilder and angular/zone.js highlight how definition errors can impact down level TypeScript consumers of a package. TypeScript should provide an option of suppressing errors that are sourced from external definition files.
In microsoft/botframework-sdk#105, the bundled TypeScript definition will produce build errors if a down level consumer's tsconfig.json file has the noImplicitAny option set. In angular/zone.js#297, the bundled definition file isn't authored as an external module which will cause a build error during a build.
To fix the build issues raised in the referenced issues a down level consumer would either need to disable sourcing definition files from NPM packages, wait for the definition fix from package author or manually patch the definition file in the package's node_modules folder.
Activity
billti commentedon Apr 18, 2016
Assigning to Ryan Cavanaugh (@RyanCavanaugh) for his thoughts, as he is working on improving our type acquisition story.
mhegazy commentedon Apr 22, 2016
This seems like a problem with the definition file that needs to be addressed. your project dependency definitions contribute to the types in your project, and if you want the compiler to flag noImplicitAny in your project, it should not exclude some just because they originated in a .d.ts file. Practically, you can not be more strict than your libraries.
The solution here would be for Microsoft/BotBuilder to be built using noImplicitAny to ensure that their users can opt into a stricter type checking mode if they so choose. this is the standard for definitions on definitelytyped as well.
Suppressing errors coming from dependnecy definitions could result in missing legitimate issue, assumes dependency on error recovery behavior on the compiler, and eventually will result in unexpected behavior for library users.
thoughtentity commentedon Apr 22, 2016
Point taken on suppressing external errors. Though I still think there should be some type of story around handling external definition errors. I think an argument can be made between your own code and external code that you don't explicitly control in terms of error handling. I don't think it's a good experience that bundled definition files picked up from npm can break the build. Especially, when it's over a minor thing such as no implicit any which shouldn't have any runtime implications.
Consider, providing an override mechanism so a down level consumer could provide their own definition file that overrides the npm package definition if error suppression is unpalatable. Right now, there is no way override definitions from npm packages if node module resolution is in play. A down level consumer would have to make an all or nothing choice if they want to take the bundled npm definitions. This would at least give down level consumers an out to unblock themselves without having to wait on the package author or manually patch the package's definition files in
node_modules.At the very least, standard guidance and best practices on how to author definitions so that they have the least impact on down level consumers should be provided to assist package authors.
mhegazy commentedon Apr 25, 2016
This should be available with TS 2.0 as part of #7156, we are doing a set of changes regarding how definition files are managed, included and acquired, see https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=label%3ATypings+
Yup. this has been rather scarce, i have to admit. different pieces are landing in place now, once that is done, the next step is providing a lot of documentation.