You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Code actions "Move to file" and "Move to new file" are shown everywhere聽#56416
imo, maybe the lightbulb shouldn't show for non-fix actions? if it's only move..., i can see how that can be annoying.
I wouldn't declare this as a generic light bulb issue, yet. Having refactoring sold by it does makes sense but it shouldn't be as spammy as it is today with 'Move...'. It seem they show unconditionally (like for loop counters or semicolons) and would benefit from some self-control, e.g only show when on a method, function, class etc ppp
Johannes Rieken (@jrieken) atm, it is just shown in every non-empty line in a method, class, function, etc. and in some files, that means the entire file and nearly every line.
Could maybe play around with only having it to show up at the line of function/class/methoid declaration, but not in the code body? Not sure if Matt Bierner (@mjbvz) has any opinions on this.
HI Nathan Shively-Sanders (@sandersn), I would like to have a go at this PR. Could I have a pointer to place in the code where the change should be, or discuss this issue with one of your team members in a meeting? We are currently looking into displaying code actions in the light-bulb menu in VS Code on empty lines too, and currently we are seeing the Move to file and Move to new file actions appearing very often. I had initially prepared a PR to patch this issue on the VS Code side, but we think ideally this fix should come directly from TypeScript
Activity
justschen commentedon Oct 26, 2023
It's unrelated to
editor.codeActionWidget.includeNearbyQuickFixes, but this does happen in every file.imo, maybe the lightbulb shouldn't show for non-fix actions? if it's only
move..., i can see how that can be annoying.vs like how we have this one to indicate quickfixable actions.
jrieken commentedon Oct 26, 2023
I wouldn't declare this as a generic light bulb issue, yet. Having refactoring sold by it does makes sense but it shouldn't be as spammy as it is today with 'Move...'. It seem they show unconditionally (like for loop counters or semicolons) and would benefit from some self-control, e.g only show when on a method, function, class etc ppp
justschen commentedon Oct 26, 2023
Johannes Rieken (@jrieken) atm, it is just shown in every non-empty line in a method, class, function, etc. and in some files, that means the entire file and nearly every line.
Could maybe play around with only having it to show up at the line of function/class/methoid declaration, but not in the code body? Not sure if Matt Bierner (@mjbvz) has any opinions on this.
mjbvz commentedon Nov 15, 2023
Some ideas:
jrieken commentedon Nov 16, 2023
馃挴 on that - showing the code action further down is noise and lowers my trust in light bulb being helpful (and not ad-space)
aiday-mar commentedon Nov 23, 2023
HI Nathan Shively-Sanders (@sandersn), I would like to have a go at this PR. Could I have a pointer to place in the code where the change should be, or discuss this issue with one of your team members in a meeting? We are currently looking into displaying code actions in the light-bulb menu in VS Code on empty lines too, and currently we are seeing the
Move to fileandMove to new fileactions appearing very often. I had initially prepared a PR to patch this issue on the VS Code side, but we think ideally this fix should come directly from TypeScriptsandersn commentedon Nov 27, 2023
Aiday Marlen Kyzy (@aiday-mar) I believe navya9singh and Andrew Branch (@andrewbranch) have worked the most on Move To File.