Skip to content

Object.getOwnPropertyDescriptors is missing from ES2017 lib d.ts #18610

Closed
Closed
Object.getOwnPropertyDescriptors is missing from ES2017 lib d.ts#18610
Labels
Domain: lib.d.tsThe issue relates to the different libraries shipped with TypeScriptFixedA PR has been merged for this issue
Milestone
TypeScript 2.6

Description

@xirzec
Jeff Fisher (xirzec)
opened on Sep 20, 2017

TypeScript Version: 2.4.2

Code

Object.getOwnPropertyDescriptors({});

Expected behavior:

Compiles with --lib es2017

Actual behavior:

Doesn't compile, missing definitions

You can see it's missing from the lib file: https://github.com/Microsoft/TypeScript/blob/master/lib/lib.es2017.object.d.ts

Reference of the implementation:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/getOwnPropertyDescriptors

Activity

  1. mhegazy commented on Sep 21, 2017

    @mhegazy
    Mohamed Hegazy (mhegazy)
    on Sep 21, 2017
    Contributor

    lib\* is just the LKG that we use to bootstrap the compiler, it has not been updated in a while.

    the definition for getOwnPropertyDescriptors should be in typescript@next. here is the definition https://github.com/Microsoft/TypeScript/blob/4d2aa9bf2cef463df1cfea3b206eb3f04e1ca765/src/lib/es2017.object.d.ts#L30.

    this was added by #18175

  2. Mohamed Hegazy (mhegazy)
    added
    FixedA PR has been merged for this issue
    on Sep 21, 2017
  3. Mohamed Hegazy (mhegazy)
    added this to the TypeScript 2.6 milestone on Sep 21, 2017
  4. Mohamed Hegazy (mhegazy)
    added
    Domain: lib.d.tsThe issue relates to the different libraries shipped with TypeScript
    on Sep 21, 2017
  5. Mohamed Hegazy (mhegazy)
    closed this as completedon Sep 21, 2017
  6. microsoft
    locked and limited conversation to collaborators on Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Domain: lib.d.tsThe issue relates to the different libraries shipped with TypeScriptFixedA PR has been merged for this issue

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions