Skip to content

Attr.cloneNode() should return Attr, not Node #1260

Open
Open
Attr.cloneNode() should return Attr, not Node#1260

Description

@fonsp
Fons van der Plas (fonsp)
opened on Feb 4, 2022

Expectation

Attr extends Node, but Attr.cloneNode() returns a new Attr, not just a Node.

Chrome dev tools:

Schermafbeelding 2022-02-04 om 23 47 06

Reality

But in lib.dom.d.ts, its return type is Node. This can give false errors, like this example from the VS Code TS linter:

Schermafbeelding 2022-02-04 om 23 43 52

Activity

  1. IllusionMH commented on Feb 23, 2022

    @IllusionMH
    Andrii Dieiev (IllusionMH)
    on Feb 23, 2022
    Contributor

    It's just special case of microsoft/TypeScript#283
    #811 was reverted as it broke libs in DefinitelyTyped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions