Repository navigation
Slai Agent Runtime:Allow opt-in DNS servers for Linux test sandboxes - #66
Open
Slai.life (huong8373tt-beep) wants to merge 1 commit into
Open
Slai.life (huong8373tt-beep) wants to merge 1 commit into
Slai.life (huong8373tt-beep) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some published Linux benchmark tests depend on public DNS but inherit Docker Engine's resolver configuration unchanged. In the
kubernetes__kops-17519replay,TestNvidiaand many unrelated integration tests stopped before their assertions because lookups ofexample.comthrough the engine resolver (192.168.65.7) returnedi/o timeoutorno such host.The candidate changes NVIDIA configuration, not DNS. The same resolver fault therefore turns an external network condition into a candidate verdict.
A local Docker control establishes that the runtime can use a reviewed explicit resolver when needed:
Hard-coding a resolver for every task would change normal sandbox behavior. RepoLaunch currently lacks a narrow, explicit launch control for the evaluator to select a resolver only for a reviewed network-dependent task.
Change
SWE_BENCH_LIVE_DOCKER_DNShandling when a Linux task container is created.dnsargument.For a reviewed task, an evaluator can opt in explicitly:
Validation
Tests cover preserving the default Docker resolver and forwarding a whitespace/empty-entry-separated DNS list.
This is runtime plumbing only. It does not modify benchmark metadata, test patches, candidate patches, or scoring; choosing a resolver remains an explicit evaluator decision.