Repository navigation
Use typed parameter values in the examples - #8683
Merged
Jens Hedegaard Nielsen (jenshnielsen) merged 1 commit intoOct 28, 2026
Merged
Jens Hedegaard Nielsen (jenshnielsen) merged 1 commit into
Jens Hedegaard Nielsen (jenshnielsen) merged 1 commit into
Conversation
The on/off parameters of these drivers are now annotated as bool, so pass True and False rather than the strings and integers that the on/off value mapping also accepts. The mapping sends the same command for both. The state of a Rigol DG1062 channel is annotated as str and sent as is, so pass "ON" to turn the output on.
Jens Hedegaard Nielsen (jenshnielsen)
requested a review
from a team
as a code owner
October 28, 2026 06:22
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8683 +/- ##
=======================================
Coverage 75.02% 75.02%
=======================================
Files 307 307
Lines 32506 32506
=======================================
Hits 24389 24389
Misses 8117 8117 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Cina Arjmand (CinaArjmand)
approved these changes
Oct 28, 2026
Jens Hedegaard Nielsen (jenshnielsen)
deleted the
typed_parameter_values_in_examples
branch
October 28, 2026 09:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The on/off parameters of these drivers are now annotated as bool, so pass True and False rather than the strings and integers that the on/off value mapping also accepts. The mapping sends the same command for both. The state of a Rigol DG1062 channel is annotated as str and sent as is, so pass "ON" to turn the output on.