Repository navigation
Pass Lakeshore channel classes explicitly - #8574
Open
Jens Hedegaard Nielsen (jenshnielsen) wants to merge 5 commits into
Open
Jens Hedegaard Nielsen (jenshnielsen) wants to merge 5 commits into
Jens Hedegaard Nielsen (jenshnielsen) wants to merge 5 commits into
Conversation
Jens Hedegaard Nielsen (jenshnielsen)
requested a review
from a team
as a code owner
October 8, 2026 06:45
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8574 +/- ##
==========================================
- Coverage 72.37% 72.37% -0.01%
==========================================
Files 307 307
Lines 32397 32396 -1
==========================================
- Hits 23447 23446 -1
Misses 8950 8950 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Jens Hedegaard Nielsen (jenshnielsen)
force-pushed
the
fix/lakeshore-channel-class-typing
branch
from
October 8, 2026 19:07
d4b7ddb to
b1c6cbf
Compare
Jens Hedegaard Nielsen (jenshnielsen)
force-pushed
the
fix/lakeshore-channel-class-typing
branch
from
October 10, 2026 12:48
b1c6cbf to
350120e
Compare
Mikhail Astafev (astafan8)
approved these changes
Oct 12, 2026
| @@ -0,0 +1,11 @@ | |||
| The Lakeshore drivers are now typed more precisely. ``LakeshoreBase`` is generic in | |||
Contributor
There was a problem hiding this comment.
why is the file named with branch name and not the PR number? :)
| self, | ||
| name: str, | ||
| address: str, | ||
| channel_class: type[ChanType_co], |
Contributor
There was a problem hiding this comment.
perhaps worth noting as a half-breaking change for those who happened to develop more lakeshoe drivers on top of the original pattern?
Tie each driver's runtime channel class to its generic channel type instead of relying on an independently overridden class attribute. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use explicit Any specializations for all shared Lake Shore channel and output parent annotations so model-specific instruments remain assignable independently of generic variance. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The output and sensor channel base classes named the generic LakeshoreBase as their parent type, which resolves to LakeshoreBase[Any] and discards the channel type. Parameterize them on a new non-generic base instead, so channel.parent is typed exactly.
Jens Hedegaard Nielsen (jenshnielsen)
force-pushed
the
fix/lakeshore-channel-class-typing
branch
from
October 13, 2026 05:17
5254b0d to
b92f76e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tie each driver's runtime channel class to its generic channel type instead of relying on an independently overridden class attribute.