Repository navigation
Fix for issue 2970 Pass enum value list when ReturnEnumsAsPrimitive parses schema enum #2970 - #3089
Open
David Oku (MasterOfLogic1) wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Pass schema enum values when
ReturnEnumsAsPrimitiveis enabledDescription
Fixes #2970
Summary
When OpenAPI parameters use inline
enumon the schema (string or integer),TryGetOptionSetcan return a primitive type whenConnectorSettings.ReturnEnumsAsPrimitiveis true. Those code paths were passing the wronglistargument intoConnectorType: they reused the variable from thex-ms-enum-valuespath, which is often null when onlyschema.enumis present.This change passes the dictionary built from
schema.Enum(dic) so enum value metadata is available for connector parsing (including integer enums covered byenum-integer.jsonandOpenApiParserTests.EnumTypeInteger).Note: Integer enum support for unsupported operations was added in #2977; this PR corrects primitive-mode value list wiring for inline schema enums.
Changes
OpenApiExtensions.cs—ReturnEnumsAsPrimitivebranches forOpenApiStringandOpenApiIntegerschema enums now uselist: dicwith the appropriateFormulaType/isNumberflags.Test plan
OpenApiParserTests.EnumTypeIntegerOpenApiParser*tests (net462)Microsoft.PowerFx.Connectors.Tests(net462): 564 passed, 16 skipped