[Hardik K (hardikkaurani)]

Summary

When copying an \OpenApiOperation\ or \OpenApiDocument\ via copy constructors (
ew OpenApiOperation(operation)\ /
ew OpenApiDocument(document)), the \Tags\ property was previously converted into a default
ew HashSet(...)\ /
ew HashSet(...).

This caused two issues:

1. If the source operation or document used custom tag collections (such as \SortedSet, custom comparer \HashSet, or \ImmutableSortedSet), copying the instance stripped the collection type and destroyed any custom ordering or custom equality comparers.
2. In \OpenApiOperation,
   ew HashSet(operation.Tags)\ did not pass \OpenApiTagComparer.Instance, causing an unnecessary secondary re-allocation in the \Tags\ property setter.

Changes

• Updated \OpenApiOperation(OpenApiOperation)\ copy constructor to pattern-match \operation.Tags\ preserving \SortedSet, custom comparer \HashSet, \ImmutableSortedSet, or falling back to \HashSet\ with \OpenApiTagComparer.Instance.
• Updated \OpenApiDocument(OpenApiDocument?)\ copy constructor to similarly pattern-match \document?.Tags\ preserving collection types and comparers.
• Added comprehensive unit tests in \OpenApiOperationTests.cs\ and \OpenApiDocumentTests.cs\ verifying preservation of collection types, comparers, ordering, and deep copy isolation.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Hardik K (hardikkaurani)]

Hi Vincent Biret (@baywet)! Following up on the custom tag collection support in #3128, this PR ensures that copy constructors in both OpenApiOperation and OpenApiDocument also preserve custom tag collection types (SortedSet, custom comparer HashSet, ImmutableSortedSet) and maintain collection deep-copy isolation. Unit tests covering all scenarios are included. Whenever you have a moment, please take a look. Thank you!

[Vincent Biret (baywet)]

Hardik K (@hardikkaurani) can you please solve the conflicts here?

[Hardik K (hardikkaurani)]

Vincent Biret (@baywet) Yes thanks for the review !

Just doing the chnages.

[Hardik K (hardikkaurani)]

Hi Vincent Biret (@baywet),

I have rebased the branch onto the latest \main\ and resolved the conflicts caused by the squash-merge of #3128. The branch is now clean and up to date.

Thank you!

[Copilot]

🟢 Approval recommended

No blocking issues were identified in the focused changes; regression tests cover the changed behavior but were not executed.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Hardik K (hardikkaurani)]

Hi Vincent Biret (@baywet),

I have updated the PR in commit 9730962 addressing your review feedback:

• Refactored the tag normalization and cloning logic in OpenApiOperation into a shared static method CopyTags(ISet<OpenApiTagReference>? tags, bool clone = false), used by both the Tags property setter and the copy constructor.
• Similarly refactored OpenApiDocument to use a shared static CopyTags(ISet<OpenApiTag>? tags, bool clone = false) for both the property setter and copy constructor.
• Eliminated code duplication while preserving custom tag collection types (SortedSet, custom-comparer HashSet, ImmutableSortedSet) and deep copy independence.

Ready for your review! Thank you!

[Vincent Biret (baywet)]

Hardik K (@hardikkaurani) can you please solve the conflicts? (there were multiple parallel PRs on this topic, keep the minimal amount of changes in this PR)

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Hardik K (hardikkaurani)]

Hi Vincent Biret (@baywet),

I have rebased the branch onto the latest main and resolved the conflicts.

As suggested, since #3116 was merged and already handles OpenApiOperation, I kept the changes in this PR minimal and strictly scoped to OpenApiDocument:

• Refactored OpenApiDocument to use a common static CopyTags(ISet<OpenApiTag>? tags, bool copy = false) for both the Tags property setter and copy constructor.
• Preserved custom tag collection types and comparers (SortedSet, custom comparer HashSet, ImmutableSortedSet) during copy construction.
• Added corresponding unit tests in OpenApiDocumentTests.cs covering custom comparer, SortedSet, and ImmutableSortedSet preservation.

The PR is now clean, minimal, and mergeable. Ready for your review! Thank you!