Skip to content

Implement IEquatable/ICloneable for all classes in the model hierarchy? #537

Closed as duplicate
Closed as duplicate
Implement IEquatable/ICloneable for all classes in the model hierarchy?#537
Labels
type:enhancementEnhancement request targeting an existing experience

Description

@OlliMartin
Olli Martin (OlliMartin)
opened on Dec 14, 2020

Hi,

I'm having quite some issues with comparing OpenApiSchema objects to other ones.
My workaround for now is to create Extension Methods to compare the hierarchy against another one.
(Which leads to a different set of problems)

What are your thoughts about implenting at least IEquatable<T|OpenApiSchema> for OpenApiSchema to allow this?

Kind regards & thanks for your work
Olli

Edit: Same goes for Cloneable as well.
Edit2: I'm dumb
Edit3: Is there any intention I'm not seeing why this was left out? What I'm seeing, it should be possible to create a generic implementation for equals and clone for the time being.

Activity

  1. Olli Martin (OlliMartin)
    changed the title [-]Make OpenApiSchema partial or implement IEquatable for all classes in the model hierarchy?[/-] [+]Implement IEquatable/ICloneable for all classes in the model hierarchy?[/+] on Dec 14, 2020

  2. darrelmiller commented on Feb 13, 2021

    @darrelmiller
    Darrel (darrelmiller)
    on Feb 13, 2021
    Member

    This sounds like a great idea to me. ICloneable would be really useful. IEquatable is partially useful. We already have two submissions for comparison capabilities. I want to be really careful about creating even more code to maintain.
    Would a comparision capability meet your needs for IEquatable?

  3. Darrel (darrelmiller)
    added
    type:enhancementEnhancement request targeting an existing experience
    on Feb 13, 2021

  4. OlliMartin commented on Feb 14, 2021

    @OlliMartin
    Olli Martin (OlliMartin)
    on Feb 14, 2021
    Author

    Comparison is totally enough.

    I quickly looked through some of the classes, is there any suggested approach of how to implement ICloneable?
    For the model I think it should be mostly straight forward, but the Any models (IOpenApiAny) could be a bit trickier.

    I will try to create a feat branch today and see how it's going.

  5. darrelmiller commented on Feb 21, 2021

    @darrelmiller
    Darrel (darrelmiller)
    on Feb 21, 2021
    Member

    Ugh, I really don't like those OpenApiAny things. I'll take a look and see if I have any suggestions.

  6. baywet commented on Dec 22, 2025

    @baywet
    Vincent Biret (baywet)
    on Dec 22, 2025
    Member

    A couple of updates:

    • We've replaced the OpenApiAny infrastructure with JsonNode from System.Text.Json, this simplifies a lot of things and provides a much better experience.
    • We've implemented copy (shallow) constructors.
    • For the remaining aspect, the comparison, there's already an issue tracking this. I'll close this issue as duplicated so we can have a federated conversation over there.
  7. Vincent Biret (baywet)
    closed this as a duplicateof OpenApiComparer is not implemented #414 on Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:enhancementEnhancement request targeting an existing experience

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions