Skip to content

Update vscode-jsonrpc to 10 and refresh lock file - #1389

Merged
microbit-matt-hillsdon merged 1 commit into
mainfrom
deps/rescue-renovate
Nov 3, 2026
Merged

microbit-matt-hillsdon merged 1 commit into
mainfrom
deps/rescue-renovate

Conversation

@microbit-matt-hillsdon

Copy link
Copy Markdown
Collaborator

Replaces #1387 and #1388, which both failed to build.

vscode-languageserver-protocol 3.18.5 (a patch release) moved to vscode-jsonrpc 10. Because we also depend on vscode-jsonrpc ^9 directly, that installed a second copy, and pyright.ts failed to typecheck with mismatched MessageConnection types. This PR moves our direct dependency to ^10 and refreshes the lock file with npm update. That gives the same set of upgrades as lock file maintenance, plus marked 18.1.2 from #1387.

  • typecheck and unit tests pass
  • e2e: 73/75 passed in the full run. The 2 simulator failures pass when run alone, on this branch and on main

vscode-languageserver-protocol 3.18.5 depends on vscode-jsonrpc 10, so our
direct ^9 dependency installed a second copy and the MessageConnection types
no longer matched. Also picks up the lock file maintenance and minor/patch
updates from #1387 and #1388.
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Preview build will be at
https://review-python.microbit.org/deps-rescue-renovate/

@microbit-matt-hillsdon
microbit-matt-hillsdon merged commit 2ea1c84 into main Nov 3, 2026
3 checks passed
@microbit-matt-hillsdon
microbit-matt-hillsdon deleted the deps/rescue-renovate branch November 3, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant