Repository navigation
NotRequired[...] built at runtime for introspection reported as invalid-annotation #5429
Description
Describe the Bug
from typing import Any, get_origin
from typing_extensions import NotRequired
def mark_optional(hints: dict[str, Any]) -> dict[str, Any]:
return {key: NotRequired[hint] for key, hint in hints.items()}
assert get_origin(mark_optional({"a": int})["a"]) is NotRequired$ pyrefly check t.py
ERROR `NotRequired` is not allowed in this context [invalid-annotation]
--> t.py:7:18
|
7 | return {key: NotRequired[hint] for key, hint in hints.items()}
| ^^^^^^^^^^^^^^^^^
INFO 1 error
other type checkers are fine with it
In this example, NotRequired is used for runtime checks. An example of where this pattern is used is in huggingface-hub:
- https://github.com/huggingface/huggingface_hub/blob/a43cbe33148ae6f7ca27568922c1968b69e822d8/src/huggingface_hub/dataclasses.py#L337-L352
- https://github.com/huggingface/huggingface_hub/blob/a43cbe33148ae6f7ca27568922c1968b69e822d8/src/huggingface_hub/dataclasses.py#L479-L482
Sandbox Link
(Only applicable for extension issues) IDE Information
No response
Activity
Allow building type qualifiers like `NotRequired[...]` at runtime
Allow building type qualifiers like `NotRequired[...]` at runtime