Repository navigation
[Flow] Fix typed static super access - #2254
OP-Prajwal wants to merge 1 commit into
Conversation
|
Hi @OP-Prajwal! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Fixes #2252.
Handle
superproperty access and method calls in static class methods correctly in Flow checking and IR generation. Ensure generic method specializations use the correctthistype for each subclass.Add tests for static
superproperties, methods, and accessors, and for rejecting static access to an instance field.Verification: full Release build and lit suite passed (2,003 tests; 0 unexpected failures).