Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermescon both x86-64 and native Linux ARM64 runners in the npm release workflow.hermesc/linuxarm64-bin/hermescinhermes-compiler, while retaining the existinglinux64-binbinary and path.Fixes #2194.
Validation
hermescCMake target in a native Linux ARM64 Ubuntu 24.04 container using the release build flags. The binary ran--version(HBC bytecode version 99) and produced a nonempty.hbcfile from a sample JavaScript input. The final optionalfileinspection in that container was unavailable because the minimal image lacksfile(1); compilation and bytecode generation completed before that command.npm pack --dry-run --jsonincludes both Linux compiler paths in a staging package.node --checkon the packaging script, and rangit diff --check.This supplies the ARM64 host binary. Consumers that hard-code
linux64-binwill still need to select the new path when running on Linux ARM64.