Skip to content

Convert sidebar_buttons component to typescript #430

Closed

Description

@ayusht2810

We plan to migrate the gitlab plugin webapp over to TypeScript to facilitate better code quality. This Help Wanted issue is to modify the above mentioned file and associate test files (if the file exists).

Below is a checklist of items you should be doing to migrate:

  • Rename the files to their associated TypeScript extensions (ie. js to ts, jsx to tsx).
  • Add relevant types in the component(s) code.
  • Update any components using those to the correct imports.
  • Fix any errors generated by the TypeScript compiler. You can run rpm run check-types to display any errors.
    We are aiming to be as strict as possible for the time being, but if you run into any issues where the file cannot be successfully migrated without significant change in other libraries, or our tsconfig.json, please feel free to raise them as we are aiming to keep this process smooth and gradual, while enforcing as much as we can.

Some examples of already migrated files can be found here:

Activity

  1. Willy-Wakam commented on Jan 9, 2024

    @Willy-Wakam
    Contributor

    Can I work on this?

  2. ayusht2810 commented on Jan 9, 2024

    @ayusht2810
    ContributorAuthor

    Thanks, @Willy-Wakam!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Help WantedCommunity help wantedTypescript MigrationIssues that requires typescript migration

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions