Skip to content

Convert link_tooltip component to typescript #424

Closed

Description

@ayusht2810

We plan to migrate the gitlab plugin webapp over to TypeScript to facilitate better code quality. This Help Wanted issue is to modify the above mentioned file and associate test files (if the file exists).

Below is a checklist of items you should be doing to migrate:

  • Rename the files to their associated TypeScript extensions (ie. js to ts, jsx to tsx).
  • Add relevant types in the component(s) code.
  • Update any components using those to the correct imports.
  • Fix any errors generated by the TypeScript compiler. You can run rpm run check-types to display any errors.
    We are aiming to be as strict as possible for the time being, but if you run into any issues where the file cannot be successfully migrated without significant change in other libraries, or our tsconfig.json, please feel free to raise them as we are aiming to keep this process smooth and gradual, while enforcing as much as we can.

Some examples of already migrated files can be found here:

Activity

  1. the-illuzion commented on Dec 21, 2023

    @the-illuzion

    Hi, @mickmister @ayusht2810, can you please assign this issue to me

  2. removed
    Up For GrabsReady for help from the community. Removed when someone volunteers
    on Dec 23, 2023
  3. added
    Up For GrabsReady for help from the community. Removed when someone volunteers
    on Nov 1, 2025
  4. christinabrgs commented on Oct 20, 2026

    @christinabrgs

    @marianunez is this still issue still needed? If so I would like to work on it :)

  5. marianunez commented on Oct 20, 2026

    @marianunez
    Member
  6. avasconcelos114 commented on Oct 20, 2026

    @avasconcelos114
    Member

    Hi @christinabrgs! Thank you for reaching out and for the interest in contributing to the Gitlab plugin :)

    From what I can see this component has already been converted to TypeScript in PR #457 so I'll go ahead and close this issue in particular as it no longer applies (Thank you for bringing this to our attention! 🙏 )

    There are however, still a couple of files that could benefit from a TypeScript conversion:

    1. components/sidebar_buttons/index.js
    2. components/rhs_sidebar/index.js

    Both of these are connector containers and would be nice if they were to make use of the types already exposed by webapp/src/types/store.ts to ensure type safety.

    Let me know if you'd be interested in making such a contribution, I'd be happy to create an issue for you to own :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions