Skip to content

Proguard is weak #19

Open
Open

Description

@iamwahyd

Hi,

I see in consumer-proguard-rules.pro these lines.:

-keep public class * {
public protected *;
}

if we include this library in a multi module project, Proguard keep ALL classes, even those are not in this library. (Indeed Android Studio Plugin append all Proguard files)

Activity

  1. matecode commented on Mar 1, 2019

    @matecode
    Owner

    What is the right way to keep the public classes of this lib? should i instead use

    -keep public class de.mateware.snacky.* {
        public protected *;
    }
    
  2. SebastianIRodriguez commented on Feb 24, 2020

    @SebastianIRodriguez

    What is the right way to keep the public classes of this lib? should i instead use

    -keep public class de.mateware.snacky.* {
        public protected *;
    }
    

    This seems much better, because it'll only affect the library code and not the entire project in which it is used.
    With the current configuration I can't correctly obfuscate a project in which I'm using Snacky. This fix would be very much appreciated.

  3. amarilindra commented on Apr 9, 2020

    @amarilindra

    Is the Proguard issue fixed in current version?

  4. matecode commented on Apr 9, 2020

    @matecode
    Owner

    changed the consumer proguard file, hope everything is fine now ... looking for feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions