Repository navigation
Conversation
|
Hi @sean0407! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary
Replace removed
matplotlib.cm.get_cmapcalls in the three OpenSfM plotting/import scripts withmatplotlib.pyplot.get_cmap. This preserves named and default colormap behavior. Closes #1116.Evidence
hasattr(matplotlib.cm, "get_cmap")returnedFalse.depth_colormappaths and theplot_graphpath completed. The named/defaultpyplot.get_cmappaths andScalarMappablecolor conversion passed.git diff --check, Python AST parsing of all three changed files, andpatch_policy.pypassed (3 files, 7 changed lines, no binary changes).Merge Danger
Door: two-way
Blast Radius: narrow
Only colormap lookup calls in three scripts change; reverting restores the previous behavior.