Repository navigation
Conversation
Tapping Update while the carb field is focused ran the guardrail check and then the form validation right after it. The guardrail alert reset the field to 0, so the validation replaced it with the empty-amount alert, or for a Trio meal with fat or protein, with the confirmation showing 0 g carbs. The validation now skips when an alert is already showing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a value over the max carbs, fat or protein setting is entered on the Loop carb edit or Trio meal edit screen and Update is tapped, the guardrail alert with the minimum and maximum now stays up until dismissed. The follow-up validation is skipped while an alert is showing, so it can't replace the guardrail message with the empty-amount alert or with a confirmation showing 0 g carbs.