Repository navigation
Conversation
simlay
marked this pull request as ready for review
October 30, 2023 02:49
This was referenced Nov 9, 2023
This was referenced Jan 18, 2024
Closed
Contributor
Author
|
Superseeded by #97 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to add the apple silicon tvOS simulator support and also add some CI for releases.
This CI addition is based off my personal resume CI. Right now it will just create a github "release" called
nightlywhen a PR is merged (assuming CI actually works). This could also use a "tag" as a workflow parameter but it's been my experience that adding lots of options to github CI tends to make it more brittle. Perhaps a manual change of name for a given release from "nightly" (to a version) might be best.