Retain confirmed payment contract bindings by j0sh · Pull Request #40 · livepeer/node

j0sh · 2026-11-03T23:25:23Z

Depends on #39. Merge after that PR.

Payment observations confirm and retain RoundsManager, TicketBroker, and BondingManager addresses at their canonical block. Warm payment reads reuse those addresses without another Controller lookup. Dependent values are read only after address confirmation; transaction, redemption, and finalized settlement resolution remain independent.

Uses the shared observer and counting fixture, with coverage for replacements within a round, simultaneous round/address changes, invalid registry results, and reorgs. Reused code retains its source attribution.

Validation: affected payment suites, go test -race ./..., go vet ./..., and diff checks passed.

Closes #32.

Source-Repository: https://github.com/livepeer/go-livepeer Original-Commit: 5b9e5d615412f5dd4cbf09aa4f4675fa1403dfb2 Source-Scope: eth/client.go:setContracts

Source-Repository: https://github.com/livepeer/go-livepeer Original-Commit: d8c313f2a4b5c865b3003cfde7f2ed5bbabdfd5b Source-Scope: eth/client.go:setContracts

Source-Repository: https://github.com/livepeer/go-livepeer Original-Commit: 0206872169a5cd748f61ca23d0507d7bac62546a Source-Scope: eth/client.go:setContracts

Source-Repository: https://github.com/livepeer/go-livepeer Original-Commit: 94d8edca933350d9587e76ef5a83066dccfcfd05 Source-Scope: eth/client.go:setContracts

- Introduces LivepeerETHTicketBroker - Code cleanup: Remove job related code Source-Repository: https://github.com/livepeer/go-livepeer Original-Commit: 26435c28edf62e40dbd6cfea97cdb750ff51abb5 Source-Scope: eth/client.go:setContracts

Source-Repository: https://github.com/livepeer/go-livepeer Original-Commit: ffcefd6341d14696e2718c1a42875428cd2cc953 Source-Scope: eth/client.go:setContracts

Source-Repository: https://github.com/livepeer/go-livepeer Original-Commit: ebdaed880f96e07b72288090e54f1141e8b404ab Source-Scope: eth/client.go:setContracts

Source-Repository: https://github.com/livepeer/go-livepeer Original-Commit: 35d719cf8634152d381e03fe95e80fa8ce51a6e6 Source-Scope: eth/client.go:setContracts

Source-Repository: https://github.com/livepeer/go-livepeer Original-Commit: 8efdade723c1ab3a7d25e8345c7e8fdade013083 Source-Scope: eth/client.go:setContracts

Source-Repository: https://github.com/livepeer/go-livepeer Original-Commit: 9803e912541cde2433e1f90fb4818491f9f4584b Source-Scope: eth/client.go:setContracts

Source-Repository: https://github.com/livepeer/go-livepeer Original-Commit: 3209dd946bb0376308044055b6caf262fd25cf61 Source-Scope: eth/client.go:setContracts

* feat(ai): enable AI orchestrator discovery This commit incorporates the AIServiceRegistry contract address, superseding the conventional ServiceRegistry contract address. This strategic alteration streamlines the discovery process of AI Orchestrators within the AI Subnet, thereby bolstering network accessibility and interaction. While this approach serves as a swift workaround to enable the feature without extensive code modification, it's important to note that it may disrupt the existing transcoding discovery mechanism. We have to fix this if we want to merge the two networks in the future. * docs(ai): improve discovery documentation This commit ensures that people are aware that they have to interact with the `AIServiceRegistry` using their main Orch wallet. * fix: fix 'AIServiceRegistry' devnet and testnet issue This commit ensure that the hardcoded `AIServiceRegistry` contract doesn't break the go-livepeer binary on local devnets or testnets. Source-Repository: https://github.com/livepeer/go-livepeer Original-Commit: e9258f301ca923d2acca9bdc8cd6d3263f4a2dbc Source-Scope: eth/client.go:setContracts

…ubnet (#3186) Source-Repository: https://github.com/livepeer/go-livepeer Original-Commit: f3fd9121ad95e1e8b89a75721ae536d60a3d1b84 Source-Scope: eth/client.go:setContracts

This commit adds functionality to the `go-livepeer` CLI, allowing orchestrators to vote on active treasury proposals directly. Additionally, it provides an option to include a reason for their vote, enhancing transparency and accountability in the decision-making process. Co-authored-by: Victor Elias <victor@livepeer.org> Source-Repository: https://github.com/livepeer/go-livepeer Original-Commit: 89d9ebc7fff0004aab11bbb733035327da7b2e1b Source-Scope: eth/client.go:setContracts

Confirm all payment registry addresses at each observer candidate's canonical block before reading its round state. Reuse the immutable tuple for payer and activity reads while keeping direct settlement and transaction resolution. Adapted-from: livepeer/go-livepeer eth/client.go at 597f882cb9f4d42ad8430b0f592afd5929af4a6b Original-Commit: 829cd9047c46aef03ff5bf07b3e34be810694b74 (Nico Vergauwen) Original-Commit: 3209dd946bb0376308044055b6caf262fd25cf61 (Rafal Leszko) Adapted-from: BlueClawNetwork/livepeer-node eth/chainview.go at 2d95d40 (Mike Zupper) Adapted-from: BlueClawNetwork/livepeer-node eth/chainview_test.go at 7e3a51e (Mike Zupper) Retain the scoped go-livepeer source history as an additional parent. Its original authors, committers, dates, and messages are preserved; Original-Commit records upstream identities. This commit owns the Node adaptation and integration. Source-Repository: https://github.com/livepeer/go-livepeer Source-Revision: 597f882cb9f4d42ad8430b0f592afd5929af4a6b Source-History: ea4881e

Copilot

🟢 Approval recommended

No active review issues are reported for the change to reuse confirmed payment contract addresses and avoid repeated Controller lookups.

No open issues 🎉

What changed in this PR

This PR extends the shared payment observer to retain contract addresses confirmed at each observation’s canonical block, eliminating repeated Controller lookups on warm payment reads while keeping redemption and finalized settlement resolution independent.

Changes:

Confirm all three payment contract addresses before reading dependent values and retain them in observer snapshots.
Extend the counting RPC fixture with block-specific contract addresses and address-specific results.
Add coverage for registry replacements, invalid results, reorgs, warm lookup counts, and independent settlement paths.

File	Description
`internal/test/chainrpc.go`	Support registry changes, address-specific responses, and finalized reads in the fixture.
`eth/payment.go`	Retain confirmed addresses in snapshots and reuse them for payment reads.
`eth/payment_contracts.go`	Add registry confirmation and scoped address reuse, with source attribution.
`eth/payment_contracts_test.go`	Test registry changes, failures, lookup counts, and finalized-read independence.
`eth/contracts_test.go`	Verify redemption resolves the live broker independently of the observer.

_{Review effort: Balanced}

Copilot

🟡 Changes recommended

The new helper breaks compilation because required types, methods, and imports are missing, and its retained bindings are unused by payment reads, leaving repeated Controller lookups unresolved.

2 open issues

Fix compilation errors in retained-contract helper · New
Use retained addresses for payment reads · New

_{Review effort: Balanced}

+func (c *client) setContracts(opts *bind.TransactOpts) error {
+	c.setTransactOpts(*opts)


+		glog.Errorf("Error creating TicketBroker binding: %v", err)
+		return err
+	}
+	c.ticketBroker = broker
