Repository navigation
Conversation
The image was installing the floating nightly toolchain, which makes builds non-reproducible and can break whenever nightly changes. Install the stable 1.99.1 release instead, pinned via RUST_VERSION so it is a one line change to bump. Pass --default-toolchain none to the rustup installer so it does not also install a floating stable toolchain next to the pinned one. Signed-off-by: Mukesh Kumar Chaurasiya (IBM) <mkchauras@gmail.com>
mkchauras
changed the title
|
The PR description is a bit out-of-date? The RUST=1 support is already merged, this PR just pins the rust version. The actual change looks good. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds Rust build support to the CI scripts. If you pass RUST=1 to the kernel build, the container switches to clang and runs make rustavailable before it compiles anything. That way, a missing or incompatible Rust toolchain fails the build straight away, not halfway through. The Ubuntu image now installs Rust through rustup with a small script, rust-install.sh. The script skips Ubuntu releases older than 24.04, since they can't support it. It's pinned to stable Rust 1.99.1 instead of nightly, so builds don't change under you. It also installs rust-src and bindgen. I tested the image and the toolchain check on Ubuntu 24.04, and both worked. The full kernel build still fails on an unrelated error in the kernel source, which is outside these changes.