[balazscsaba2006]

Summary

• Schedule::isDue() treated null lastTriggeredAt (new job, no cron_dates entry) as a missed run because PHP evaluates null < DateTime to true
• This caused every new scheduled job to fire immediately on deploy, regardless of its cron expression
• New jobs now correctly wait for their first scheduled time

Root cause

// null < $this->cronExpression->getPreviousRunDate() -> always true in PHP
if ($lastTriggeredAt < $this->cronExpression->getPreviousRunDate()) {
    return true;
}

Impact

This bug was latent since the initial commit (June 2022). It went unnoticed because:

• Daily/hourly jobs: firing on deploy is usually harmless (they would run that day anyway)
• PostDeployment jobs: have their own shouldRun() that intentionally fires on null
• Weekly jobs: first affected when added day-specific weekly job -- deploying on Friday caused Tuesday/Wednesday jobs to fire immediately

Fix

Added $lastTriggeredAt !== null guard to both comparison branches. When lastTriggeredAt is null (new job), isDue() now falls through to CronExpression::isDue(now) -- which correctly checks if the current time matches the cron schedule.

Test plan

• All 37 tests passing
• PHPStan clean
• Release as patch version (2.3.1)

[Copilot]

Pull request overview

Fixes Schedule::isDue() so that brand-new scheduled jobs (with null lastTriggeredAt) don’t get treated as “missed” and run immediately on deploy; instead they wait until they’re actually due per the cron expression.

Changes:

• Add null guards in Schedule::isDue() before comparing lastTriggeredAt to computed dates.
• Update and expand test coverage to assert new jobs don’t fire immediately when not due, and still do fire when due.
• Adjust ScheduleBasedCronJob behavior tests to reflect the corrected scheduling semantics.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/Cron/Schedule.php	Prevents null lastTriggeredAt from triggering “missed run” logic; falls back to cron isDue(now) evaluation.
tests/Cron/ScheduleTest.php	Moves/extends assertions to cover “new job + not due” and “new job + due” behavior.
tests/Cron/CronJobImplementationTest.php	Updates missed-run test to be due “now” and adds coverage ensuring new jobs don’t run when not currently due.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

These assertions depend on real wall-clock time while Schedule::isDue() calls Carbon::now()/CarbonImmutable::now() internally. If the test runs across a minute boundary, everyDay($now->hour, $now->minute) (and similar time-matching assertions in this file) can become non-due and make the test flaky. Consider freezing time with CarbonImmutable::setTestNow(...) (and resetting afterwards) around tests that expect exact minute matches.

[Copilot]

getSchedule() uses CarbonImmutable::now()->minute, but Schedule::isDue() also fetches its own now internally. If execution crosses a minute boundary between those calls, this test can become flaky (schedule minute and evaluation minute differ). Freezing time via CarbonImmutable::setTestNow(...) in the test (and resetting after) would make this deterministic.