Repository navigation
fix: give parallel Gemini tool calls distinct tool_use ids - #151
Merged
lich0821 merged 1 commit intoOct 27, 2026
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Gemini is the upstream,
GeminiRespToClaudeandGeminiStreamToClaudebuilt everytool_useid ascall_<function name>. Gemini sends no call ids, so two calls to the same tool in one turn (parallelread_filecalls, for instance) came back with identical ids, and Claude Code could not tell whichtool_resultbelongs to which call.Both paths now use
newGeminiToolUseID(), which returnscall_plus a UUID. The id-to-name map used when the history is converted back (convertClaudeContentToGeminiParts) still resolves the function name from the id, so thefunctionResponsekeeps the right name.New tests send a Gemini response with two
read_filecalls through the non-streaming and the streaming conversion and require two distinct ids. Both fail onmaster(both ids arecall_read_file) and pass with the change, together with the rest of./internal/transformer/.... Not run against the live Gemini API.This change was prepared with AI assistance (Claude Code).
🤖 Generated with Claude Code