Repository navigation
fix: report Rex pane-close failures - #64
Merged
Merged
Conversation
Keep Cmd+W confirmation for foreground programs that do not report activity. Surface launch and close errors, distinguish unavailable process metadata, and use a conventional action title. Native close controls remain Rex-owned; the detached helper's remote routing remains a known limitation. Remove the `RexAppUpdateAutomation` and `Workspace.showsProcessesInActivity` overrides because Rex's defaults now match them. Manage the chosen 10 pt vertical padding. Clarify app and server lifecycles and avoid version-specific update button names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report API, helper-launch, and close-command failures from the custom
Cmd+Waction, and distinguish unavailable process metadata. Rename it toClose Pane with Confirmation. Foreground-process confirmation still covers programs that report no Rex activity; the shell classifier and native close controls are unchanged. Remote-server routing through the detached helper remains a known limitation.Use Rex's matching automatic-update and show-each-process defaults, and manage vertical padding at 10 pt. Correct the app/server lifecycle documentation and point update warnings to server settings without relying on a button name.
Validated seven Lua behavior partitions in an isolated Rex runtime, including baseline ablation, and native subprocess success, failure, and cancellation paths with dialog presentation stubbed. The deployed configuration loads without diagnostics.