Skip to content

Add root .gitignore (PM_GH_REPO_005) - #1

Open
anish-sujanani wants to merge 1 commit into
mainfrom
pmsec/gitignore
Open

anish-sujanani wants to merge 1 commit into
mainfrom
pmsec/gitignore

Conversation

@anish-sujanani

Copy link
Copy Markdown

Add a root .gitignore

Addresses PM_GH_REPO_005 — All repositories must define a .gitignore file.

This repository has no .gitignore at its root. One new file, 32 lines, nothing else.

What was chosen and why

The language signal for this repository resolves to the generic minimal template.

Verification

  • Exactly one file in the diff, at the repository root; no nested .gitignore touched.
  • Every already-tracked file was checked against the new rules with
    git check-ignore --no-index — no tracked file matches any of them.
  • .env.* precedes !.env.example deliberately: git applies the last matching pattern, so
    reversing them would ignore a committed example file too.

Break risk

None at runtime. Adding a .gitignore changes nothing about existing tracked files and
nothing about CI.

Generic minimal template (gitignore-playbook.md 2a): no language template justified for this repository.

@nitpickybot nitpickybot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Review Summary

Adds a minimal root .gitignore covering OS/editor noise, logs, and .env variants. The pattern ordering for .env.example is correct (last match wins). Nothing blocking; one minor note on .vscode/ if the repo ever wants to share editor config.

  • 🔵 1 suggestion(s)

Review Scope

  • Mode: Full pull request
  • Range: Full pull request through ca34ee45e94d2296c97c21861c8ff0f3ed506b08
  • Current range coverage: Complete
  • Cumulative pull request coverage: Complete

This review is complete for the current scope. Addressing all critical and warning findings above satisfies the review; suggestions are optional. Request another review only if subsequent changes introduce new behavior or materially expand the pull request's scope.

Comment thread .gitignore

# Editor / IDE
.idea/
.vscode/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 suggestion

Ignoring all of .vscode/ means shared settings like extensions.json, launch.json, or settings.json can never be committed. If you want to leave that door open, the usual pattern is to negate the shareable files:

Suggested change
.vscode/
.vscode/*
!.vscode/settings.json
!.vscode/tasks.json
!.vscode/launch.json
!.vscode/extensions.json

Entirely optional — fine to keep as-is if the repo has no shared editor config.

@anish-sujanani
anish-sujanani requested review from adiophir and deep-gandhii and removed request for sagivo October 14, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants