You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am currently working on adding Codacy suggestions. I would like to know some details regarding this @rajikaimal .
Codacy was showing some suggestions under the category of Error Prone which I assume that the console logs were added to display the output of this example or to display an error message.
E.g. -
Do we need to remove these console logs?
I have corrected all code style suggestions on JavaScript.
I have formatted the readme file using a markdown plugin since codacy was showing some formatting issues with readme file.
I also assumed that the security issue by using a Found non-literal argument in require in this scenario should be ignored const ncConfig = require(path.join(process.cwd(), ".nc.config"));
I would like to make any changes according to your suggestions regarding this PR @rajikaimal
Activity
rajitha1998 commentedon Jan 6, 2020
I am currently working on adding Codacy suggestions. I would like to know some details regarding this @rajikaimal .
Codacy was showing some suggestions under the category of
Error Pronewhich I assume that the console logs were added to display the output of this example or to display an error message.E.g. -
Do we need to remove these console logs?
I have corrected all code style suggestions on JavaScript.
I have formatted the
readmefile using a markdown plugin since codacy was showing some formatting issues withreadmefile.I also assumed that the security issue by using a Found non-literal argument in require in this scenario should be ignored
const ncConfig = require(path.join(process.cwd(), ".nc.config"));I would like to make any changes according to your suggestions regarding this PR @rajikaimal