Repository navigation
fix: stop modules.json getting wiped on close - #349
Merged
Merged
Conversation
The save on close ran in the background, so the game could exit before it finished and leave modules.json empty. Save before closing instead, and load the backup if the file is empty.
beanbag44
requested changes
Oct 19, 2026
beanbag44
left a comment
beanbag44
left a comment
Member
There was a problem hiding this comment.
looks good, i'd just remove the extra log which afaik wont work anyway
Contributor
|
Love this. I've experienced this countless times, especially when loading/ unloading plugins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Settings were getting reset to defaults after closing the game for some people in Discord.
The save on shutdown ran in the background, so the game could exit before it finished and leave modules.json empty... Then the next launch saw an empty file and loaded defaults instead.
With this change it should save before the game exits, and if the file is empty, it loads the backup file.