Skip to content

Check if Mockingjay include Mockingjay-Swift.h ! #106

Open

Description

@MedAmineWinners

@kylef
For pod files that do not use use_frameworks!, testing with Mockingjay returns a build error!

<Mockingjay/Mockingjay-Swift.h> file not found

So it will be better for you to add something like this in your MockingjayURLConfiguration.m
to check if include /Mockingjay-Swift.h or not.

this will make life easier for developers who use your pod to unit test their frameworks.
I tried to make a ullRequest on it, but it's not possible for me like I don't have the rights

#if __has_include("Mockingjay-Swift.h")
    #import "Mockingjay-Swift.h"
#else
    #import <Mockingjay-Swift.h/Mockingjay-Swift.h>
#endif

Activity

  1. mihailsalari commented on Mar 18, 2019

    @mihailsalari

    @kylef Please apply those changes, it works with them.

  2. fousa commented on Apr 12, 2019

    @fousa

    @kylef I have the same problem, any idea when you can manage to merge this? We love Mockingjay here, and hope we can continue to use it. 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions