Skip to content

fix(vm): sign macOS VM release artifact [HOLD: VOUCH REQUIRED] - #12

Open
kvnloo wants to merge 10 commits into
review/3506-upstream-mainfrom
fix/3506-sign-vm-release-artifact
Open

kvnloo wants to merge 10 commits into
review/3506-upstream-mainfrom
fix/3506-sign-vm-release-artifact

Conversation

@kvnloo

@kvnloo kvnloo commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

Current overlap — 2026-10-16

HOLD / PARTIALLY OWNER_COVERED, not a new upstream candidate. Florent Benoit (benoitf) already landed CI entitlement signing in origin #3507, merge 8e9136bbc388add62c4ae886b3cfdefe09a86f58. Eric Curtin owns the remaining Homebrew/installer cleanup in open origin #4566, head ba4029b5241d7613374c404503345b546c7b5f97. Keep this fork head 8c192de39f2dde289f224ebe37634870c1fb451b only for its distinct signature/packaged-artifact verification work and historical credit; do not duplicate the owner cleanup. Actual macOS packaged-artifact proof remains unexecuted here. Vouch, DCO and fresh current-base/CI gates remain separate. Queue: https://github.com/kvnloo/oss-factory/issues/67


Summary

Sign the macOS openshell-driver-vm release artifact before it leaves the build job, so direct tarball installs and Homebrew consume the same Hypervisor-entitled binary.

Promotion status: HOLD — OpenShell requires a maintainer vouch before first-time contributors may open upstream PRs. Keep this fork PR as downstream staging only.

Related Issue

Changes

  • add optional macOS entitlement signing to the shared Rust-binary build action;
  • opt the macOS VM driver into signing with its checked-in entitlement plist;
  • verify signature + Hypervisor entitlement before upload;
  • smoke-test the packaged tarball on macOS;
  • remove Homebrew-time plist generation and codesigning;
  • remove the obsolete installer formula patcher;
  • update release tests and VM release docs.

Testing

CI validates the workflow/config changes. The release pipeline additionally verifies:

  • codesign --verify --strict on the built driver;
  • com.apple.security.hypervisor=true from the signed binary;
  • the same checks after extracting openshell-driver-vm-aarch64-apple-darwin.tar.gz.

Checklist

  • Accepted upstream issue
  • Exact current upstream-main base
  • Entitlements plist remains single source of truth
  • No Homebrew-time signing remains
  • DCO sign-off on every commit
  • No unrelated files

kvnloo added 10 commits October 1, 2026 01:13
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>
Signed-off-by: Kevin Rajan <7121943+kvnloo@users.noreply.github.com>

kvnloo commented Oct 1, 2026

Copy link
Copy Markdown
Owner Author

Upstream promotion attempt on 2026-10-01 returned GitHub 403 (Resource not accessible by integration) for NVIDIA#3506.

Status remains READY TO POST. The fork branch/PR is the canonical promotion artifact until org-side write access is available.

@kvnloo

kvnloo commented Oct 1, 2026

Copy link
Copy Markdown
Owner Author

Upstream PR is open: NVIDIA#4020

The earlier 403 (Resource not accessible by integration) was the integration token, not a block on the kvnloo OAuth account. This fork PR is no longer the promotion queue.

@kvnloo

kvnloo commented Oct 1, 2026

Copy link
Copy Markdown
Owner Author

Correction: NVIDIA#4020 was created, then closed by the OpenShell first-contributor vouch bot. It is not an open upstream PR. A maintainer /vouch is required before it can stay open. Reopening without that will be closed again.

@kvnloo kvnloo changed the title fix(vm): sign macOS VM release artifact [READY TO POST] fix(vm): sign macOS VM release artifact [HOLD: VOUCH REQUIRED] Oct 1, 2026
@kvnloo kvnloo added the keep pr-janitor: never auto-close label Oct 17, 2026
@kvnloo

kvnloo commented Oct 23, 2026

Copy link
Copy Markdown
Owner Author

GEM1 verified-artifact reconciliation — U36

Recovery experiment: https://github.com/kvnloo/oss-factory/issues/221

Title/body duplicate search plus direct carrier inspection selected this existing home; no duplicate issue is being opened.

U36

  • Evidence: Existing carrier fix(vm): sign macOS VM release artifact [HOLD: VOUCH REQUIRED] #12 is OPEN at 8c192de.
  • Reconstruction: Use this exact carrier/head and its current state/hold; compare later recovered bytes before reviving or duplicating work.
  • Acceptance (NOT RUN): Satisfy this carrier's documented project/platform acceptance and attribution/review gates on its actual current base before any further publication.
  • Boundary: Current state overrides historical READY wording. Closed/held items were not reopened; no upstream action, merge or new acceptance run.

This is artifact/ownership reconciliation only. No tests, builds, native UI/device runs, upstream publication or merge were performed by this promotion pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

keep pr-janitor: never auto-close

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant