Repository navigation
Conversation
- Replace react-native-androw bitmap shadows with native shadow*/elevation, fixing the (NOBRIDGE) 'bubblingEventTypes of null' crash on bridgeless RN (#48) - Render inner day cards with map() instead of a nested FlatList, removing the VirtualizedList nesting warning and related layout glitches (#48, #49) - Use flex:1 container + trimmed contentInset, dropping the ScreenHeight/maxHeight hacks that left large empty space on Android (#49) - Derive stable keys from date/title instead of array index - Type renderItem as ListRenderItem<ITimeline> (no more item: any) - Stop spreading rest props onto the FlatList; useWindowDimensions for reflow - Memoize leaf components; fix Card's baseUrl-relative models import - Add per-card accessibilityLabel; hide the decorative point from screen readers - Add named exports + typed forwarded props via lib/index.tsx
- Migrate build to react-native-builder-bob (CJS + ESM + types in dist/) with a proper exports/module/react-native/types field map; keep default export and bare package-name import resolvable - Repoint repository/bugs/homepage to kuraydev (npm name unchanged) - Declare react/react-native peerDependencies (wide ranges) + peerDependenciesMeta - Remove react-native-androw and @freakycoder/react-native-helpers runtime deps - Replace dead tslint script + legacy .eslintrc.js with ESLint 9 flat config - Drop obsolete devDeps (typescript-transformer, npm-post-install, prettier-format, @types/react-native, community eslint config); upgrade TS 5 / Prettier 3 / husky 9 - Add files allowlist, source field, lint-staged config; fix husky hooks
Covers rendering, default/custom dateFormat, style forwarding, empty data, accessibility labels, the single-VirtualizedList regression for #48, and absence of the legacy Androw component.
…lates Node 18/20 matrix runs install, typecheck, lint, format check, tests, and build on push/PR, replacing the dead Travis-era setup.
- Full props/API table (data, timelineStyle, dateFormat, *TextStyle, point/dash) - TypeScript usage, Expo + New Architecture note, migration guide - Fix badges/links to kuraydev; label moment/dash as bundled deps and react/ react-native as the real peers - Keep-a-Changelog CHANGELOG, CONTRIBUTING with backward-compat rules
kuraydev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review fixes applied: moved the
react-native-builder-bobesm: trueflag from the top-level config into themoduletarget ([["commonjs"],["module",{"esm":true}],["typescript"]]) to silence the cosmetic⚠ The esm option is disabled, but the exports['.'].require/import field is setbuild warning. Output is unchanged.package.jsonversion left at2.0.0(matches the documented major bump; no tag or npm publish triggered).This branch (
chore/deep-overhaul-2026) was produced by a concurrent agent that shared the same local checkout as me. While I was doing the overhaul, a siblingclaudeprocess was independently committing and pushing the same branch (HEADis already ==origin/chore/deep-overhaul-2026). Itsgit reset/checkout operations repeatedly wiped my working-tree edits within seconds, so I could not land an independent commit without risking its already-pushed work. The diff described below is the sibling agent's committed overhaul (8 commits ahead ofmaster), which I inspected viagit show. Treat the "Open items" section as a review checklist before merge. This is the exact "never share a checkout" hazard noted in the project's own history.Summary
Brings the 3.75-year-stale library up to 2026 standards: fixes the New Architecture crash, removes dead/heavy native dependencies, migrates the build to
react-native-builder-bobwith a properexportsmap, replaces deadtslinttooling, adds a real Jest test suite + GitHub Actions CI, and rewrites the README with an accurate props table.Non-breaking improvements
repository/bugs/homepagefrom the legacy WrathChaos/freakycoder URLs togithub.com/kuraydev/...(npm package name unchanged).react/react-nativepeerDependencies(none existed before) +peerDependenciesMeta.tslintlint script with ESLint; migrated to a flat config; upgraded TypeScript 4→5, ESLint 7→9-era, Prettier 2→3; removed obsolete devDeps (react-native-typescript-transformer,npm-post-install,prettier-format,@types/react-native,@react-native-community/eslint-config,eslint-config-airbnb).FlatList(inner cards now render withmap) — kills the VirtualizedList-nesting warning.Dimensions.get('screen')captures withuseWindowDimensionsso the timeline reflows on rotation; dropped the Android half-screenmaxHeighthack and the 30%-of-screen bottomcontentInsetthat caused the empty space in Styling Issue #49.React.memoon leaf components.import { ITimelineData } from "lib/models"baseUrl import → relative.CHANGELOG.md(Keep a Changelog),CONTRIBUTING.md, issue templates + PR template, and a Node 18/20 CI matrix (install + prettier + lint + typecheck + test + build).@testing-library/react-nativesuite.Breaking changes (recommend major: 1.0.1 → 2.0.0)
react-native-androw(the New Architecture crashCannot read property 'bubblingEventTypes' of null, (NOBRIDGE) ERROR Warning: TypeError: Cannot read property 'bubblingEventTypes' of null #48) and@freakycoder/react-native-helpers; card shadows now use nativeshadow*+ Androidelevation. Android shadow rendering changes slightly.mainmoved from./build/dist/Timeline.jstodist/commonjs/index.jswith anexports/module/types/react-nativemap. Barereact-native-beautiful-timelineimport + default export still resolve.react-nativepeer floor raised to>=0.61.Verification
Local checks (run against my rewrite before the working tree was reset by the sibling agent):
tsc --noEmitclean,eslintclean,prettier --checkclean,bob buildproduced dual CJS/ESM + d.ts with default+named exports, 14 Jest tests passing. The committed branch state was not re-verified with a fresh build because the shared checkout was being reset continuously.Open items the reviewer should confirm before merge
package.jsonversion was self-bumped to2.0.0in-branch — the overhaul brief said to recommend a bump, not set it. Confirm this is intended (it should be done by the release flow, not the PR).lib/index.tsandlib/index.tsx(duplicate entry, ambiguous resolution); a later commit removedindex.tskeepingindex.tsx. Verify the canonical entry resolves andsource/exportspoint at it.esmenabled, top-leveltypesisdist/typescript/index.d.tsbut esm output emitsdist/typescript/{commonjs,module}/index.d.ts— confirm thetypespath isn't dangling.momentwas kept (not swapped fordayjs) — fine and conservative, but the 2.0.0 install still ships moment; reconsider if install size was a goal.Closes #48. Addresses #49.