Repository navigation
docs: use template.kubevirt.io/v1beta1 in README examples - #137
Conversation
template.kubevirt.io/v1alpha1 is deprecated in both CRDs and every request against it prints a deprecation warning. Switch the remaining README examples to v1beta1; the v1beta1 samples differ from the v1alpha1 ones only in apiVersion. Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: YoungjuKim <fjvbn2003@gmail.com>
|
Hi @fjvbn2003. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/ok-to-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ksimon1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@fjvbn2003 Thanks for your contribution! |
What this PR does / why we need it:
template.kubevirt.io/v1alpha1is markeddeprecated: truein both CRDs. Every request against it returns a warning:However, the README's Quick Example, the "VirtualMachineTemplate CRD" example and the "apply the samples" step still use v1alpha1. The VMTR section already uses v1beta1. This switches the remaining examples to v1beta1. The v1beta1 samples in
config/samples/are identical to the v1alpha1 ones apart fromapiVersion, so no fields change.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I observed the warning above on KubeVirt v1.9.0, which bundles virt-template v0.2.2. On current main, the CRD still has
deprecated: trueon v1alpha1 inconfig/crd/bases/template.kubevirt.io_virtualmachinetemplates.yamland..._virtualmachinetemplaterequests.yaml.Release note:
🤖 Generated with Claude Code