Skip to content

docs: use template.kubevirt.io/v1beta1 in README examples - #137

Merged
kubevirt-prow[bot] merged 1 commit into
kubevirt:mainfrom
fjvbn2003:docs-readme-v1beta1
Oct 19, 2026
Merged

kubevirt-prow[bot] merged 1 commit into
kubevirt:mainfrom
fjvbn2003:docs-readme-v1beta1

Conversation

@fjvbn2003

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

template.kubevirt.io/v1alpha1 is marked deprecated: true in both CRDs. Every request against it returns a warning:

$ kubectl get virtualmachinetemplates.v1alpha1.template.kubevirt.io -A
Warning: template.kubevirt.io/v1alpha1 VirtualMachineTemplate is deprecated; use template.kubevirt.io/v1beta1 VirtualMachineTemplate

However, the README's Quick Example, the "VirtualMachineTemplate CRD" example and the "apply the samples" step still use v1alpha1. The VMTR section already uses v1beta1. This switches the remaining examples to v1beta1. The v1beta1 samples in config/samples/ are identical to the v1alpha1 ones apart from apiVersion, so no fields change.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
I observed the warning above on KubeVirt v1.9.0, which bundles virt-template v0.2.2. On current main, the CRD still has deprecated: true on v1alpha1 in config/crd/bases/template.kubevirt.io_virtualmachinetemplates.yaml and ..._virtualmachinetemplaterequests.yaml.

Release note:

NONE

🤖 Generated with Claude Code

template.kubevirt.io/v1alpha1 is deprecated in both CRDs and every
request against it prints a deprecation warning. Switch the remaining
README examples to v1beta1; the v1beta1 samples differ from the
v1alpha1 ones only in apiVersion.

Assisted-by: Claude <noreply@anthropic.com>
Signed-off-by: YoungjuKim <fjvbn2003@gmail.com>
@kubevirt-prow kubevirt-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 16, 2026
@kubevirt-prow

kubevirt-prow Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Hi @fjvbn2003. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: kubevirt/virt-template/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 94654946-d84c-4311-9f07-3d2c19bed6e7
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kubevirt-prow
kubevirt-prow Bot requested review from akrejcir and ksimon1 October 16, 2026 18:53
@ksimon1

ksimon1 commented Oct 19, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@ksimon1

ksimon1 commented Oct 19, 2026

Copy link
Copy Markdown
Member

/approve
@jcanocan can you please review this PR?

@kubevirt-prow

kubevirt-prow Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-prow kubevirt-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2026
@jcanocan

Copy link
Copy Markdown
Contributor

@fjvbn2003 Thanks for your contribution!
/lgtm

@kubevirt-prow kubevirt-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2026
@kubevirt-prow
kubevirt-prow Bot merged commit 0025df2 into kubevirt:main Oct 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants