Repository navigation
docs(istio): clarify operator installation - #6749
Open
awais-ur-rehman wants to merge 1 commit into
Open
awais-ur-rehman wants to merge 1 commit into
awais-ur-rehman wants to merge 1 commit into
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
|
Welcome @awais-ur-rehman! It looks like this is your first PR to knative/docs 🎉 |
Member
|
/lgtm you'll need to sign the CLA |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awais-ur-rehman, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/hold |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Installing
net-istio.yamlmanually alongside a Knative Operator installation can conflict with the controller managed by the Operator. Add a note before the Istio installation steps explaining that Operator users still install Istio but skip the separate net-istio manifest.Fixes #6217.
Breaking Changes
None.
Testing
./hack/mkdocs.sh buildpkg/reconciler/knativeserving/ingress/ingress.goinknative/operatorand the existing Operator documentation.git diff --check