Skip to content

docs(istio): clarify operator installation - #6749

Open
awais-ur-rehman wants to merge 1 commit into
knative:mainfrom
awais-ur-rehman:feat/clarify-operator-istio-install
Open

awais-ur-rehman wants to merge 1 commit into
knative:mainfrom
awais-ur-rehman:feat/clarify-operator-istio-install

Conversation

@awais-ur-rehman

Copy link
Copy Markdown

Summary

Installing net-istio.yaml manually alongside a Knative Operator installation can conflict with the controller managed by the Operator. Add a note before the Istio installation steps explaining that Operator users still install Istio but skip the separate net-istio manifest.

Fixes #6217.

Breaking Changes

None.

Testing

  • ./hack/mkdocs.sh build
  • Checked the generated Istio installation page contains the Operator note and links to the existing Operator installation guide.
  • Verified the behavior against pkg/reconciler/knativeserving/ingress/ingress.go in knative/operator and the existing Operator documentation.
  • git diff --check

@knative-prow
knative-prow Bot requested review from Leo6Leo and creydr October 25, 2026 11:10
@netlify

netlify Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit de1ddb5
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/6adde38d2dddd1db23a3449c
😎 Deploy Preview https://deploy-preview-6749--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: awais-ur-rehman / name: awais-ur-rehman (de1ddb5)

@knative-prow knative-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 25, 2026
@knative-prow

knative-prow Bot commented Oct 25, 2026

Copy link
Copy Markdown

Welcome @awais-ur-rehman! It looks like this is your first PR to knative/docs 🎉

@dprotaso

Copy link
Copy Markdown
Member

/lgtm
/approve

you'll need to sign the CLA

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2026
@knative-prow

knative-prow Bot commented Oct 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awais-ur-rehman, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2026
@dprotaso

Copy link
Copy Markdown
Member

/hold

@knative-prow knative-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: the net-istio documentation is outdated in the case of the knative operator.

2 participants