Repository navigation
Conversation
Member
Yes, I think we should remove the entire ANSI section -- it's no longer used by any systems.
I think those lines should be removed. They don't work as provided (and without the rules, the keys will be passed unchanged to the app anyway). Keyman does not emit LF or DEL with those keys. Also see lines 2525-2526 which have the same rules. |
Contributor
Author
|
@mcdurdin ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses one keyboard in #4146
I'm still not sure if I would remove the whole ANSI section.
And, if these rules should be modified or removed: