Skip to content

[bu_phonetic] Update preparing for more vigorous validation - #4183

Open
LornaSIL wants to merge 2 commits into
keymanapp:masterfrom
LornaSIL:bu_phonetic
Open

LornaSIL wants to merge 2 commits into
keymanapp:masterfrom
LornaSIL:bu_phonetic

Conversation

@LornaSIL

@LornaSIL LornaSIL commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Addresses one keyboard in #4146

I'm still not sure if I would remove the whole ANSI section.
And, if these rules should be modified or removed:

c 
c Pass certain key combinations through unchanged to the application.
c These key combinations have special meanings to applications like Word, and so the application
c needs to see the key combination itself, not the character that it is normally translated to by Keyman.
+ [SHIFT K_ENTER]   > [SHIFT K_ENTER]       c instead of normal translation to U+000A LF
+ [CTRL K_BKSP]     > [CTRL K_BKSP]         c instead of normal translation to U+007F DEL
c NOTE TO ALBERT: This is needed on both my internal and external keyboard, so it has nothing to do with the 
c programming of the external keyboard or its connection to the computer.

@mcdurdin

Copy link
Copy Markdown
Member

I'm still not sure if I would remove the whole ANSI section.

Yes, I think we should remove the entire ANSI section -- it's no longer used by any systems.

And, if these rules should be modified or removed:

c 
c Pass certain key combinations through unchanged to the application.
c These key combinations have special meanings to applications like Word, and so the application
c needs to see the key combination itself, not the character that it is normally translated to by Keyman.
+ [SHIFT K_ENTER]   > [SHIFT K_ENTER]       c instead of normal translation to U+000A LF
+ [CTRL K_BKSP]     > [CTRL K_BKSP]         c instead of normal translation to U+007F DEL
c NOTE TO ALBERT: This is needed on both my internal and external keyboard, so it has nothing to do with the 
c programming of the external keyboard or its connection to the computer.

I think those lines should be removed. They don't work as provided (and without the rules, the keys will be passed unchanged to the app anyway). Keyman does not emit LF or DEL with those keys. Also see lines 2525-2526 which have the same rules.

@LornaSIL

Copy link
Copy Markdown
Contributor Author

@mcdurdin ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants