Repository navigation
Conversation
- Extract `_validatePackages`, `_writeRootIndexHtml`, and `_commitAndReport` from `run` (`47 -> 15`) while preserving `_prettyName` untouched. - Inline single-use `_defineValue` and extract per-directory `_deleteExtraFiles` from `runBuildRunner` (`31 -> 12`, `_deleteExtraFiles` `11`). - Flatten exception handling in `bin/peanut.dart` `main` (`26 -> 14`) and move option-parse error handling into `_getOptions` (`1 -> 5`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces cognitive complexity across
bin/peanut.dart,lib/src/build_runner.dart, andlib/src/peanut.dart(+166 / -138lines) and bumps the package version to6.0.3-wip(14/14tests pass, max cognitive complexity51 -> 15).bin/peanut.dart(mainCC 17 -> 11): Replaces nestedif (e is ...)branches insidecatchwith typedon PackageExceptionandon PeanutExceptionclauses and moves option parsing error handling into_getOptions.lib/src/build_runner.dart(runBuildRunnerCC 16 -> 6): Inlines single-use_defineValueand extracts_deleteExtraFileswith an earlycontinueguard.lib/src/peanut.dart(runCC 51 -> 15): Extracts_validatePackages,_writeRootIndexHtml, and_commitAndReportsorunreads as a linear pipeline.6.0.3-wip): Bumpspubspec.yamlandlib/src/version.dartto6.0.3-wipwith an empty## 6.0.3-wipsection inCHANGELOG.md.