Repository navigation
Conversation
kevmo314
force-pushed
the
fix-has-expired-race
branch
from
October 5, 2026 21:03
197e7f5 to
42abea3
Compare
has_expired() read self._expire_at twice. Another thread starting a request on the connection can set it to None between the reads, raising TypeError. Read it once.
kevmo314
force-pushed
the
fix-has-expired-race
branch
from
October 5, 2026 21:04
42abea3 to
de5765c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_expired()readsself._expire_attwice:If another thread starts a request on the connection between the two reads,
handle_request()sets_expire_attoNoneand the comparison raises:This is easy to hit on free-threaded Python 3.14t, for example when
huggingface_hubdownloads files on a thread pool with one shared client. The fix reads_expire_atonce, in the HTTP/1.1 and HTTP/2 connections, sync and async. New tests simulate the interleaving; they fail before the change and pass after.Checklist