Repository navigation
Fix exec platform for binary targets - #124
Merged
Merged
Conversation
Similar to b60b54e but for the binary rules
Owner
Author
|
i feel like there might be cases where this is too aggressive but we can try it and see how it goes. if so it would likely only affect people using cross platform remote exec, which is likely small |
keith
enabled auto-merge (squash)
November 3, 2025 19:48
keith
added a commit
that referenced
this pull request
Apr 10, 2026
With bazel 9.x+ we can force the rules being run to be for the target platform using the default_test_toolchain_type. This shouldn't affect behavior for older versions. Also adds a test on CI for this case. Related #113 #124 This is trying to work around bazelbuild/bazel#19645
keith
added a commit
that referenced
this pull request
May 28, 2026
With bazel 9.x+ we can force the rules being run to be for the target platform using the default_test_toolchain_type. This shouldn't affect behavior for older versions. Also adds a test on CI for this case. Related #113 #124 This is trying to work around bazelbuild/bazel#19645
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to b60b54e but for the binary
rules