Repository navigation
Harden the CI a bit - #1219
Open
woodruffw wants to merge 5 commits into
Open
Harden the CI a bit#1219woodruffw wants to merge 5 commits into
woodruffw wants to merge 5 commits into
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Contributor
Author
|
(Also, thanks for your work on pyjwt! I've been a very happy user and occasional contributor over the years 🙂) |
auvipy
self-requested a review
October 3, 2026 08:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! This is an attempt to harden pyjwt's CI and Dependabot config a bit. All of the findings come from zizmor and I've broken each into its own commit.
As a TL;DR:
actions/checkoutcalls usepersist-credentials: false, which prevents them from dumping theGITHUB_TOKENto disk (which is the default)id-token: writeto the smallest possible scope so that only the actual publishing job itself gets access to the OIDC token.stale.yml(this could have been a code execution avenue, although in practice the lack of a dangerous trigger means that the impact is not as severe).All of the above and the changes themselves are 100% human written, and I'm happy to answer any questions about them! I didn't include a zizmor integration in this PR (since not every project wants that), but I'd be happy to add one as well if you're interested (as a way to backstop any future problems).
Signed-off-by: William Woodruff william@yossarian.net