Repository navigation
[TRIAL — do not merge upstream] Configurable natural_list conjunction - #1
Draft
jon-devlapaz wants to merge 1 commit into
Draft
jon-devlapaz wants to merge 1 commit into
jon-devlapaz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Controlled Tinkery workflow replay in this personal fork. This is a trial result for operator review, not an upstream contribution or a claim that this feature is new. It replays the public request from python-humanize#214; a separate upstream implementation was already identified in python-humanize#316.
natural_listacceptsconjunction: str = "and", preserving existing defaults and allowing strings such as"or"and"and also". The change is limited to the function, its docstring and focused tests. It performs no translation.Validation at
c7011211debdde8fa95f0a698c5fed616cb1ece5:andwhile retaining the new parameter makes 11 custom cases fail; all 14 original default cases still pass. Restoring the implementation passes again.Trial trace: run
be4610f1-1e0b-4078-b938-52cd8e68fd36; seed SHA-25653f241a3821054a96bb04847354e37e72a8b87fa9408307ec721c5ff87bba19c; baseline6b817b963dbb091b9ad20a746cb6a26653a93b95. The seed was explicitly confirmed by an agent acting under operator authorization.The trial caught a faulty seed proposal: its broad
pytest -k natural_listcommand passed before the feature existed. We preserved that finding, then added real regressions and the production-only reversion check during implementation. Passing the final command does not erase the earlier failure. The related Tinkery correction is jon-devlapaz/tinkery#470.Keep this PR as a draft for the operator's judgment. Nothing is submitted to the upstream repository.