Repository navigation
Width/Height options do not work as described in instructions #5
Description
In the readme file, it says that width and height use the parent values if these options are not set. Implying that the options should have higher priority.
But the actual way it behaves is that the parent value has higher priority, and these values are only used if the parent container is too small.
Maybe should be something like this?
if(noparent)
{
width = settings.width || $elm.parent().width();
height = settings.height || $elm.parent().height();
}
else
{
$elm.append(canvas);
width = settings.width || $elm.innerWidth();
height = settings.height || $elm.innerHeight();
}
The width/height < 2 check becomes redundant if this logic is used.
Not sure if this will break existing integrations, so it might need to be a new option. Or just reflect the actual behaviour in the instructions.
Thanks
Activity
jimdoescode commentedon Feb 3, 2014
Thanks for the heads up. I'll check it out.
tapash2407 commentedon Apr 18, 2014
Height can be set by changing the code in "jquery.jqscribble.js". Please find below the code:
if(noparent)
{
width = this.parent().width();
height = this.parent().height();
}
if(width < 2)width = settings.width;
if(height < 2)height = settings.height;
Same way width can also be set.