Repository navigation
fix: resolve tornado mypy errors instead of suppressing them - #568
Merged
mergify[bot] merged 1 commit intoFeb 18, 2026
Merged
mergify[bot] merged 1 commit into
mergify[bot] merged 1 commit into
Conversation
- Add class-level sleep type annotation to TornadoRetrying so the async sleep signature is accepted without ignore_errors - Remove stale type: ignore comments from tornadoweb.py and test_tornado.py - Drop the blanket ignore_errors mypy override for tornadoweb/test_tornado Change-Id: I48134c99c48d7abe6734b34a79255fbcd3f39618
jd
marked this pull request as ready for review
February 18, 2026 15:59
Contributor
Merge Queue StatusRule:
This pull request spent 28 seconds in the queue, including 4 seconds running CI. Required conditions to merge |
mergify
Bot
deleted the
devs/jd/fix/tornado-mypy/I48134c99c48d7abe6734b34a79255fbcd3f39618
branch
February 18, 2026 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
async sleep signature is accepted without ignore_errors