[j178]

Closes #2852

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-09T12:27:05.927473Z	1aafbd6	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[prek-ci-bot]

📦 Cargo Bloat Comparison

.text size change: +0.00% (12.9 MiB → 12.9 MiB)

Expand for cargo-bloat output

Head Branch Results

File  .text     Size             Crate Name
0.1%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_45_0_aes_gcm_encrypt_avx512
0.1%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_45_0_aes_gcm_decrypt_avx512
0.0%   0.7%  94.9KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
0.0%   0.4%  50.3KiB annotate_snippets annotate_snippets::renderer::render::render
0.0%   0.4%  47.5KiB              prek <<prek::config::hook::HookWire as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<&mut <serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.3%  45.0KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<&mut <serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.3%  41.2KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
0.0%   0.3%  35.1KiB              prek prek::run::{closure#0}
0.0%   0.2%  29.5KiB      serde_saphyr <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
0.0%   0.2%  28.8KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  28.0KiB              toml <toml::de::deserializer::value::ValueDeserializer as serde_core::de::Deserializer>::deserialize_any::<<prek::config::hook::HookWire as serde_core::de::Deserialize>::deserialize::__Visitor>
0.0%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_45_0_edwards25519_scalarmuldouble_alt
0.0%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_45_0_edwards25519_scalarmuldouble
0.0%   0.2%  27.4KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.2KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.1KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  26.4KiB              prek <prek::languages::ruby::installer::RubyInstaller>::install::{closure#0}
4.1%  87.3%  11.3MiB                   And 20867 smaller methods. Use -n N to show more.
4.7% 100.0%  12.9MiB                   .text section size, the file size is 277.0MiB

Base Branch Results

File  .text     Size             Crate Name
0.1%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_45_0_aes_gcm_encrypt_avx512
0.1%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_45_0_aes_gcm_decrypt_avx512
0.0%   0.7%  91.8KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
0.0%   0.4%  50.3KiB annotate_snippets annotate_snippets::renderer::render::render
0.0%   0.4%  47.5KiB              prek <<prek::config::hook::HookWire as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<&mut <serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.3%  45.0KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<&mut <serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.3%  39.5KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
0.0%   0.3%  35.4KiB              prek prek::run::{closure#0}
0.0%   0.2%  29.5KiB      serde_saphyr <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
0.0%   0.2%  28.8KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_45_0_edwards25519_scalarmuldouble_alt
0.0%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_45_0_edwards25519_scalarmuldouble
0.0%   0.2%  27.2KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.1KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.1KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.1KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  26.9KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  26.9KiB              prek prek::cli::hook_impl::hook_impl::{closure#0}
0.0%   0.2%  26.5KiB              prek <prek::languages::ruby::installer::RubyInstaller>::install::{closure#0}
4.1%  87.3%  11.3MiB                   And 20832 smaller methods. Use -n N to show more.
4.7% 100.0%  12.9MiB                   .text section size, the file size is 277.3MiB

[prek-ci-bot]

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment

• OS: Linux 6.17.0-1022-azure
• CPU: 4 cores
• prek version: prek 0.5.5+11 (12afe30 2026-10-09)
• Rust version: rustc 1.99.0 (b940084d7 2026-09-28)
• Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

prek --version

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base --version	2.4 ± 0.1	2.2	2.6	1.00
prek-head --version	2.4 ± 0.1	2.3	3.1	1.03 ± 0.06

prek list

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base list	9.5 ± 0.1	9.2	9.8	1.00
prek-head list	9.5 ± 0.1	9.3	9.9	1.01 ± 0.02

prek validate-config .pre-commit-config.yaml

⏭️ Skipped: .pre-commit-config.yaml not found

prek sample-config

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base sample-config	2.8 ± 0.1	2.6	3.3	1.00 ± 0.05
prek-head sample-config	2.8 ± 0.1	2.6	3.2	1.00

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

prek run --all-files (cold - no cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	18.2 ± 0.9	17.4	20.8	1.02 ± 0.05
prek-head run --all-files	17.8 ± 0.2	17.5	18.2	1.00

prek run --all-files (warm - with cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	17.9 ± 0.3	17.3	18.4	1.00
prek-head run --all-files	18.4 ± 0.3	17.9	19.0	1.02 ± 0.03

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

prek run --all-files (full builtin hook suite)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --all-files	18.0 ± 0.4	17.3	18.9	1.00
prek-head run --all-files	18.2 ± 0.5	17.6	20.4	1.01 ± 0.03

Individual Hook Performance

Benchmarking each hook individually on the test repo:

prek run trailing-whitespace --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run trailing-whitespace --all-files	8.9 ± 0.2	8.5	9.2	1.01 ± 0.02
prek-head run trailing-whitespace --all-files	8.8 ± 0.1	8.5	9.0	1.00

prek run end-of-file-fixer --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run end-of-file-fixer --all-files	8.1 ± 0.1	7.9	8.5	1.00
prek-head run end-of-file-fixer --all-files	8.2 ± 0.2	7.9	8.7	1.00 ± 0.03

prek run check-json --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-json --all-files	7.1 ± 0.1	7.0	7.4	1.00
prek-head run check-json --all-files	7.2 ± 0.1	7.1	7.6	1.01 ± 0.02

prek run check-yaml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-yaml --all-files	7.4 ± 0.1	7.2	7.8	1.00 ± 0.03
prek-head run check-yaml --all-files	7.3 ± 0.2	7.1	7.7	1.00

prek run check-toml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-toml --all-files	7.2 ± 0.1	7.0	7.4	1.01 ± 0.02
prek-head run check-toml --all-files	7.1 ± 0.1	6.9	7.5	1.00

prek run check-xml --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-xml --all-files	7.3 ± 0.1	7.1	7.4	1.01 ± 0.02
prek-head run check-xml --all-files	7.2 ± 0.1	7.0	7.4	1.00

prek run detect-private-key --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run detect-private-key --all-files	7.7 ± 0.2	7.5	8.3	1.02 ± 0.03
prek-head run detect-private-key --all-files	7.6 ± 0.1	7.4	7.8	1.00

prek run fix-byte-order-marker --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run fix-byte-order-marker --all-files	7.7 ± 0.1	7.6	8.0	1.01 ± 0.02
prek-head run fix-byte-order-marker --all-files	7.6 ± 0.1	7.5	8.0	1.00

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

prek install-hooks (cold - no cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base install-hooks	4.8 ± 0.0	4.8	4.9	1.01 ± 0.02
prek-head install-hooks	4.8 ± 0.1	4.7	4.9	1.00

prek install-hooks (warm - with cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base install-hooks	4.8 ± 0.0	4.7	4.8	1.00
prek-head install-hooks	4.8 ± 0.1	4.7	4.9	1.01 ± 0.02

File Filtering/Scoping Performance

Testing different file selection modes:

prek run (staged files only)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run	11.0 ± 0.1	10.8	11.3	1.00
prek-head run	11.2 ± 0.4	10.8	12.5	1.02 ± 0.04

prek run --files '*.json' (specific file type)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --files '*.json'	5.5 ± 0.1	5.5	5.7	1.00 ± 0.02
prek-head run --files '*.json'	5.5 ± 0.1	5.4	5.7	1.00

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

prek run --dry-run --all-files (measures init overhead)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run --dry-run --all-files	7.4 ± 0.1	7.2	7.7	1.00 ± 0.02
prek-head run --dry-run --all-files	7.4 ± 0.1	7.3	7.7	1.00

Meta Hooks Performance

Benchmarking meta hooks separately:

prek run check-hooks-apply --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-hooks-apply --all-files	8.8 ± 0.1	8.6	9.1	1.00 ± 0.02
prek-head run check-hooks-apply --all-files	8.8 ± 0.1	8.6	9.0	1.00

prek run check-useless-excludes --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run check-useless-excludes --all-files	8.8 ± 0.2	8.5	9.2	1.02 ± 0.03
prek-head run check-useless-excludes --all-files	8.6 ± 0.1	8.5	8.9	1.00

prek run identity --all-files

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
prek-base run identity --all-files	7.6 ± 0.1	7.5	7.7	1.00
prek-head run identity --all-files	7.6 ± 0.2	7.4	8.0	1.00 ± 0.03

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.33%. Comparing base (34af5db) to head (769334b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2853   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files         143      143           
  Lines       30847    30865   +18     
=======================================
+ Hits        29100    29118   +18     
  Misses       1747     1747           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[redeboer]

Many thanks for the blazingly fast fix! 🙏🙇