Skip to content

Add prometheus.istio.io/scrape-targets annotation reference - #3784

Open
kaiohenricunha wants to merge 1 commit into
istio:masterfrom
kaiohenricunha:api/prometheus-scrape-targets-annotation
Open

kaiohenricunha wants to merge 1 commit into
istio:masterfrom
kaiohenricunha:api/prometheus-scrape-targets-annotation

Conversation

@kaiohenricunha

Copy link
Copy Markdown

Adds the prometheus.istio.io/scrape-targets annotation to the reference metadata. This is the annotation for multi-target Prometheus metrics merging, implemented in istio/istio#59567 (istio/istio#59924, istio/istio#59925, istio/istio#60468) and shipped in Istio 1.31.

annotation/annotations.gen.go and annotation/annotations.pb.html are regenerated from annotation/annotations.yaml via annotations_prep (same tool as make generate-annotations), following the existing prometheus.istio.io/merge-metrics entry as the pattern.

Documents the annotation for multi-target Prometheus metrics merging,
shipped in Istio 1.31 (istio/istio#59567). Generated files regenerated
via annotations_prep.
Copilot AI lite review requested due to automatic review settings September 16, 2026 11:40
@kaiohenricunha
kaiohenricunha requested a review from a team as a code owner September 16, 2026 11:40
@istio-policy-bot

Copy link
Copy Markdown

😊 Welcome @kaiohenricunha! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Sep 16, 2026
@istio-testing

Copy link
Copy Markdown
Collaborator

Hi @kaiohenricunha. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

1 similar comment
@istio-testing

Copy link
Copy Markdown
Collaborator

Hi @kaiohenricunha. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kaiohenricunha

Copy link
Copy Markdown
Author

@keithmattix @howardjohn @frittentheke Companion PR to istio/istio.io#17621, registering prometheus.istio.io/scrape-targets in the annotations reference source. Appreciate a review when you get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants