Repository navigation
Add prometheus.istio.io/scrape-targets annotation reference - #3784
kaiohenricunha wants to merge 1 commit into
Conversation
Documents the annotation for multi-target Prometheus metrics merging, shipped in Istio 1.31 (istio/istio#59567). Generated files regenerated via annotations_prep.
|
😊 Welcome @kaiohenricunha! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
Hi @kaiohenricunha. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 similar comment
|
Hi @kaiohenricunha. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@keithmattix @howardjohn @frittentheke Companion PR to istio/istio.io#17621, registering |
Adds the
prometheus.istio.io/scrape-targetsannotation to the reference metadata. This is the annotation for multi-target Prometheus metrics merging, implemented in istio/istio#59567 (istio/istio#59924, istio/istio#59925, istio/istio#60468) and shipped in Istio 1.31.annotation/annotations.gen.goandannotation/annotations.pb.htmlare regenerated fromannotation/annotations.yamlviaannotations_prep(same tool asmake generate-annotations), following the existingprometheus.istio.io/merge-metricsentry as the pattern.