This repository was archived by the owner on Nov 18, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 18, 2021. It is now read-only.
Automatically turn "+1" comments into a thumbs-up #968
Description
A suggestion for improving Github Issues on large projects:
If someone leaves a comment consisting entirely of "+1" pop up a message telling them that you've converted it into a thumbs-up for the issue, and subscribe them to it.
For bonus points, also do so for a thumbs-up emoji.
See microsoft/vscode#1023 for an example of an issue where the majority of the comments are this kind of thing.
Reacted by Preston Martin, Jeremy Day, Nils Schönwald, Andreas Reich, Michael Keck, Daniel Chick, Ryan Naddy, Daniel Imms, TPS, zo and 42 more
Reacted by Jakub Čábera and Piotr
Activity
bluemoehre commentedon Jul 13, 2017
+1 =D
schoenwaldnils commentedon Jul 13, 2017
+1
JayFoxRox commentedon Jul 14, 2017
I'm not sure about this: the problem is that people are stupid.
I don't think we should encourage this or give them a "quick-command" when there is an equivalent function they can use which is just as simple.
imo such comments should just be deleted / people should use the existing button.
It could also be a confusing feature:
I think "large projects" should just improve their review style, moderation and user/developer education if they depend on this feature.
cirosantilli commentedon Jul 14, 2017
Related: #640 #967
guilhermedecampo commentedon Jul 15, 2017
+1
Tyriar commentedon Jul 18, 2017
Stupid is a bit harsh, some people are new to GitHub. This is about reducing noise for maintainers caused by these people who aren't familiar with the feature. Some projects even take the effort of setting up a bot to automatically delete the comment which is bad because of the effort spent and they completely lose the voice of the user.
A nudge in the right direction could solve the problem. It could be as simple as something like this:
Not particularly intrusive, still allows you to do it if you really want to and likely fixes the problem at the root, with zero cost to the maintainers of countless projects.
tziporaziegler commentedon Jul 19, 2017
@Tyriar That is what I already suggested here: #967.
Automatically turning +1's into thumbs up can be confusing, since users will just be left wondering where their +1 disappeared to. By prompting users with a message explaining that +1 comment do not add value to the conversation and explaining that the user should instead use reactions, you are giving a clearer message of what behavior is wanted on this site. This is the reason I think my suggestion to blacklist reactions makes more sense, and do not think automatically turning +1's into reactions is a good idea.
Tyriar commentedon Jul 20, 2017
@tziporaziegler two solutions to the same problem, I hope the actual solution has more thought put into it than the 5 minutes I invested 😃
TPS commentedon Jul 20, 2017
Duplicates (my 😉) #640, right?
Tyriar commentedon Jul 20, 2017
Well they're different as they're different solutions. Really they should both be under an issue posing the problem, not the solution. eg. "Prevent 👍/+1 spam"
martinvonwittich commentedon Jan 28, 2019
What makes +1 comments especially annoying to me is that some maintainers opt to lock issues where people post these, while advising people to use the reaction feature instead. But what the maintainers usually aren't aware of is that locking issues actually also locks the reactions (#771) :(